Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Review client config file format and management #8

Open
rtamalin opened this issue Jun 4, 2024 · 1 comment
Open

Config: Review client config file format and management #8

rtamalin opened this issue Jun 4, 2024 · 1 comment
Labels
Config enhancement New feature or request question Further information is requested SDK

Comments

@rtamalin
Copy link
Collaborator

rtamalin commented Jun 4, 2024

Currently the client config file is a YAML file and the telemetry client library leverages the gopkg.in/yaml.v3 package to access it.

However this library doesn't appear to be be well maintained, with many open issues, and no code activity in approx 2 years. Therefore, switching to a better maintained package to provide YAML parsing capabilities would appear to be a good idea, with sigs.k8s.io/yaml looking to be the best candidate.

Alternatively we could just switch to a JSON file, though doing so would complicate matters as regards supporting comments into the config file.

Alternatively we could implement a simplified YAML-like format similarly to how SUSE/connect-ng manages it's config file.

@rtamalin rtamalin added enhancement New feature or request Config SDK labels Jun 4, 2024
@rtamalin
Copy link
Collaborator Author

rtamalin commented Jun 4, 2024

This may have implications for #7

@rtamalin rtamalin added the question Further information is requested label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config enhancement New feature or request question Further information is requested SDK
Projects
None yet
Development

No branches or pull requests

1 participant