Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds checks to decide whether or not to compress data #29

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Adds checks to decide whether or not to compress data #29

merged 5 commits into from
Jul 10, 2024

Conversation

gbuenodevsuse
Copy link
Collaborator

Addresses #12

@gbuenodevsuse gbuenodevsuse mentioned this pull request Jul 8, 2024
Merged
rtamalin
rtamalin reviewed Jul 9, 2024
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
rtamalin
rtamalin reviewed Jul 9, 2024
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
rtamalin
rtamalin reviewed Jul 9, 2024
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
rtamalin
rtamalin reviewed Jul 10, 2024
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
rtamalin
rtamalin requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak recommended. Otherwise looks good.

@gbuenodevsuse @rtamalin
Update pkg/utils/utils_test.go
2865d22 
Co-authored-by: Fergal Mc Carthy <[email protected]>
rtamalin
rtamalin approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbuenodevsuse gbuenodevsuse merged commit 86ad051 into main Jul 10, 2024
1 check passed
@rtamalin rtamalin deleted the improvements_to_datastore_compression branch July 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtamalin rtamalin rtamalin approved these changes

@mbelur mbelur Awaiting requested review from mbelur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbuenodevsuse @rtamalin