Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add host refresh operation #126

Merged
merged 1 commit into from
Sep 9, 2024
Merged

✨ Add host refresh operation #126

merged 1 commit into from
Sep 9, 2024

Conversation

fanshan
Copy link
Contributor

@fanshan fanshan commented Sep 6, 2024

No description provided.

@fanshan fanshan self-assigned this Sep 6, 2024
config.js Outdated Show resolved Hide resolved
@fanshan fanshan force-pushed the host_refresh_operation branch 2 times, most recently from 921351e to 88b3cee Compare September 6, 2024 14:59
@fanshan fanshan requested a review from lvenier September 6, 2024 15:26
Copy link
Collaborator

@linkdd linkdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the debug nodes?

Should we also consider using more "sub flows"? The API - POST flow is getting out of hand (spreading in 2 directions: left and bottom).

@fanshan
Copy link
Contributor Author

fanshan commented Sep 9, 2024

Maybe remove the debug nodes?

Should we also consider using more "sub flows"? The API - POST flow is getting out of hand (spreading in 2 directions: left and bottom).

Done for debug node.

I think some housekeeping for flows redability should be done ;-)

@fanshan fanshan merged commit ebac8d7 into main Sep 9, 2024
1 check passed
@fanshan fanshan deleted the host_refresh_operation branch September 9, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants