Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Container's image should not be changed #123

Open
fanshan opened this issue May 8, 2024 · 4 comments
Open

✨ Container's image should not be changed #123

fanshan opened this issue May 8, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed V4

Comments

@fanshan
Copy link
Collaborator

fanshan commented May 8, 2024 •
edited
Loading

Netbox version Plugin Version Agent version Docker API Version
3.7.* 1.8.0 * *

Actual Behavior

Container's image can be changed.

Desired Behavior

Container image cannot be changed. We need to remove this feature.

Instead, we should only give the right to change the image version.
@fanshan fanshan added enhancement New feature or request good first issue Good for newcomers labels May 8, 2024
@lvenier
Copy link
Collaborator

lvenier commented May 10, 2024

@fanshan Im not sure I understand the issue. Changing container image is a good required feature. Why removing it ?

@fanshan
Copy link
Collaborator Author

fanshan commented May 13, 2024 •
edited
Loading

You are right, I close.

@fanshan fanshan closed this as completed May 13, 2024
@lvenier lvenier reopened this May 13, 2024
@lvenier
Copy link
Collaborator

lvenier commented May 13, 2024

After discussion I understand.

We should not change the image but only changing the image version.

@fanshan
Copy link
Collaborator Author

fanshan commented May 13, 2024

Updated issue contents.

@lvenier lvenier added the help wanted Extra attention is needed label May 21, 2024
@lvenier lvenier changed the title Container's image should not be changed ✨ Container's image should not be changed Jun 6, 2024
@lvenier lvenier added the V4 label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed V4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fanshan @lvenier