Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add "not_sync" flag on container #131

Open
lvenier opened this issue May 21, 2024 · 0 comments
Open

✨ add "not_sync" flag on container #131

lvenier opened this issue May 21, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed V4

Comments

@lvenier
Copy link
Collaborator

lvenier commented May 21, 2024

Netbox version Plugin Version Agent version Docker API Version
3.7.* 1.11.0 * *

Actual Behavior

When I reconfigure a container (changing labels, mounts, ports...) the changes will not be applied until I recreate the container.
If I make a change it is highly possible I forgot to recreate or want to postpone the recreation but nobody would know

Desired Behavior

I believe we should flag a container as soon as a change has been applied and the recreate has not been triggered.
This way I would know that the actual configuration of my container in the plugin and the actual docker being run is different.

As soon as the recreate is triggered the flag is removed.

@lvenier lvenier added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers enhancement New feature or request and removed bug Something isn't working labels May 21, 2024
@lvenier lvenier changed the title add "not_sync" flag on container ✨ add "not_sync" flag on container May 22, 2024
@lvenier lvenier added the V4 label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed V4
Projects
None yet
Development

No branches or pull requests

1 participant