Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ prevent exec on non running container #138

Open
lvenier opened this issue Jun 6, 2024 · 5 comments
Open

⚡ prevent exec on non running container #138

lvenier opened this issue Jun 6, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed V4

Comments

@lvenier
Copy link
Collaborator

lvenier commented Jun 6, 2024

Netbox version Plugin Version Agent version Docker API Version
4.* 2.* * *

Actual Behavior

It is possible to run exec command on a non running container :

image

Desired Behavior

if the container is not running we should prevent to run exec command on the container :

image

@lvenier lvenier added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed bug Something isn't working labels Jun 6, 2024
@amrutharajashekar
Copy link

I would like to work on this issue , could you assign this to me. Thanks!.

@lvenier
Copy link
Collaborator Author

lvenier commented Jun 9, 2024

I would like to work on this issue , could you assign this to me. Thanks!.

This is yours. thanks for your support.

@lvenier
Copy link
Collaborator Author

lvenier commented Jul 1, 2024

I would like to work on this issue , could you assign this to me. Thanks!.

@amrutharajashekar : any help needed ?

@lvenier lvenier added the V4 label Jul 3, 2024
@amrutharajashekar
Copy link

Hi Really sorry i did not get time to work on this , some one else can pick this up ?

@lvenier
Copy link
Collaborator Author

lvenier commented Jul 15, 2024

Hi Really sorry i did not get time to work on this , some one else can pick this up ?

No urgency. I was just asking in case you were struggling to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed V4
Projects
None yet
Development

No branches or pull requests

2 participants