Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Add xtermjs terminal to Exec tab in container view #163

Open
linkdd opened this issue Oct 4, 2024 · 1 comment
Open

🚸 Add xtermjs terminal to Exec tab in container view #163

linkdd opened this issue Oct 4, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed V3 V4

Comments

@linkdd
Copy link
Collaborator

linkdd commented Oct 4, 2024

Netbox version Plugin Version Agent version Docker API Version
3.6.* & 4.* 1.* & 2.* 0.35.* *

Actual Behavior

The Exec tab is built around a text input which sends the command to the agent and then display the logs in a div bellow.
The user experience is not that great.

Desired Behavior

Using https://xtermjs.org, we could improve the user experience by providing a fake terminal. For a first iteration, we could have a fake prompt that sends the command to the agent just like now, for a future update (when the agent supports forwarding the pty), we could attach a real shell to the fake terminal.

@linkdd linkdd added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers V3 V4 labels Oct 4, 2024
@linkdd linkdd changed the title ✨ Add xtermjs terminal to Exec tab in container view 🚸 Add xtermjs terminal to Exec tab in container view Oct 4, 2024
@fanshan
Copy link
Collaborator

fanshan commented Oct 4, 2024

There is initiative around Docker and Websocket that can be usefull to consult about the subjet of this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed V3 V4
Projects
None yet
Development

No branches or pull requests

2 participants