Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for config context in volumes #95

Open
dzove855 opened this issue Mar 6, 2024 · 1 comment
Open

add support for config context in volumes #95

dzove855 opened this issue Mar 6, 2024 · 1 comment
Labels
enhancement New feature or request question Further information is requested V4

Comments

@dzove855
Copy link
Member

dzove855 commented Mar 6, 2024

Netbox version Agent version Docker API Version
v3.6.9 / /

Actual Behavior

There is no way to add config context to be mounted inside a container

Desired Behavior

An new type should be added for volumes, which we can use inside the agent to map mount a config context inside a container

Example of use cases:

  • you have a config file with for example a nginx configuration, we would use the config context who contains the config and the mount it inside the container where the path should be

Expected structure:
Destination path of the file
Config context
Driver (something like configmap or just configcontext)

@dzove855 dzove855 added the enhancement New feature or request label Mar 6, 2024
@lvenier
Copy link
Collaborator

lvenier commented May 6, 2024

Would you plan to keep context on the volume itself as per below ?

buzko@lovespizza:~$ docker volume create dzove --label country=croatia,luxembourg --label birthday=01/01/1970
dzove
buzko@lovespizza:~$ docker inspect dzove
[
    {
        "CreatedAt": "2024-05-06T16:28:20+02:00",
        "Driver": "local",
        "Labels": {
            "birthday": "01/01/1970",
            "country": "croatia,luxembourg"
        },
        "Mountpoint": "/var/lib/docker/volumes/dzove/_data",
        "Name": "dzove",
        "Options": null,
        "Scope": "local"
    }
]

if not "add host" will make you lose that information

@lvenier lvenier added question Further information is requested V4 labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested V4
Projects
None yet
Development

No branches or pull requests

2 participants