Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Add Truce and Ally relation to FriendlyFire #225

Open
ghost opened this issue Oct 27, 2022 · 0 comments
Open

Feature Request - Add Truce and Ally relation to FriendlyFire #225

ghost opened this issue Oct 27, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Oct 27, 2022

Is your feature request related to a problem? Please describe.
FriendlyFire is only toggleable for faction members inside a faction, TRUCE and ALLY relations are unaffected by this and FriendlyFire remains disabled, no matter the settings. (Yes this also happens when ff is toggled via API)

Describe the solution you'd like
Either make TRUCE and ALLY relation be affected by FriendlyFire settings or add a seperate way for these relations to toggle friendlyfire. Would be much appreciated.

Describe alternatives you've considered
I've considered trying to find the codesection where that damage is cancelled, altering it and submitting a pr but this sourcecode is old so I have no Idea if that even makes any sense to do.

@ghost ghost added the enhancement New feature or request label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants