Skip to content

Commit 2179d9d

Browse files
nusheanikiwastaken
andcommitted
fix navigation and some visual issues
Co-authored-by: niki <295591807+nikiwastaken@users.noreply.github.com> Signed-off-by: Shea <nu@she-a.eu>
1 parent de07c02 commit 2179d9d

6 files changed

Lines changed: 129 additions & 95 deletions

File tree

src/app/components/message/modals/Options.tsx

Lines changed: 28 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@ export function OptionMenu({
599599
onReactionToggle(mEvent.getId() ?? '', key, shortcode);
600600
onTotalClose();
601601
}}
602-
count={isModal ? 6 : 4}
602+
count={isModal ? 8 : 4}
603603
/>
604604
)}
605605
<Box direction="Column" gap="100" className={css.MessageMenuGroup}>
@@ -615,6 +615,23 @@ export function OptionMenu({
615615
</Text>
616616
</MenuItem>
617617
)}
618+
619+
{canEditEvent(mx, mEvent) && onEditId && isModal && (
620+
<MenuItem
621+
size="300"
622+
after={menuIcon(PencilSimple)}
623+
radii="300"
624+
data-event-id={mEvent.getId()}
625+
onClick={() => {
626+
onEditId(mEvent.getId());
627+
onTotalClose();
628+
}}
629+
>
630+
<Text className={css.MessageMenuItemText} as="span" size="T300" truncate>
631+
Edit Message
632+
</Text>
633+
</MenuItem>
634+
)}
618635
{/* Only show "Add to User Sticker Pack" if the sticker isn't already in the default pack and isn't encrypted */}
619636
{isStickerMessage &&
620637
mEvent.getContent().url &&
@@ -654,35 +671,35 @@ export function OptionMenu({
654671
Reply
655672
</Text>
656673
</MenuItem>
657-
{canEditEvent(mx, mEvent) && onEditId && (
674+
{!isThreadedMessage && (
658675
<MenuItem
659676
size="300"
660-
after={menuIcon(PencilSimple)}
677+
after={menuIcon(ChatCircleDots)}
661678
radii="300"
662679
data-event-id={mEvent.getId()}
663-
onClick={() => {
664-
onEditId(mEvent.getId());
680+
onClick={(evt) => {
681+
onReplyClick(evt, true);
665682
onTotalClose();
666683
}}
667684
>
668685
<Text className={css.MessageMenuItemText} as="span" size="T300" truncate>
669-
Edit Message
686+
Reply in Thread
670687
</Text>
671688
</MenuItem>
672689
)}
673-
{!isThreadedMessage && (
690+
{canEditEvent(mx, mEvent) && onEditId && !isModal && (
674691
<MenuItem
675692
size="300"
676-
after={menuIcon(ChatCircleDots)}
693+
after={menuIcon(PencilSimple)}
677694
radii="300"
678695
data-event-id={mEvent.getId()}
679-
onClick={(evt) => {
680-
onReplyClick(evt, true);
696+
onClick={() => {
697+
onEditId(mEvent.getId());
681698
onTotalClose();
682699
}}
683700
>
684701
<Text className={css.MessageMenuItemText} as="span" size="T300" truncate>
685-
Reply in Thread
702+
Edit Message
686703
</Text>
687704
</MenuItem>
688705
)}

src/app/features/navigate/NavigateModal.tsx

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import FocusTrap from 'focus-trap-react';
22
import {
33
Avatar,
44
Box,
5+
color,
56
config,
67
IconButton,
78
Input,
@@ -133,9 +134,10 @@ export type RoomSearchPickRoomConfig = {
133134
export type RoomSearchModalProps = {
134135
requestClose?: () => void;
135136
pickRoom?: RoomSearchPickRoomConfig;
137+
isMobile?: boolean;
136138
};
137139

138-
export function RoomSearchModal({ requestClose, pickRoom }: RoomSearchModalProps) {
140+
export function RoomSearchModal({ requestClose, pickRoom, isMobile }: RoomSearchModalProps) {
139141
const mx = useMatrixClient();
140142
const useAuthentication = useMediaAuthentication();
141143
const scrollRef = useRef<HTMLDivElement>(null);
@@ -307,7 +309,10 @@ export function RoomSearchModal({ requestClose, pickRoom }: RoomSearchModalProps
307309
<Box
308310
shrink="No"
309311
grow="Yes"
310-
style={{ padding: config.space.S400, paddingBottom: 0, width: '100%' }}
312+
style={{
313+
padding: `${config.space.S400} ${isMobile ? config.space.S0 : config.space.S400} 0`,
314+
width: '100%',
315+
}}
311316
direction="Column"
312317
>
313318
<Input
@@ -396,7 +401,7 @@ export function RoomSearchModal({ requestClose, pickRoom }: RoomSearchModalProps
396401
data-space={room.isSpaceRoom()}
397402
onClick={handleRoomClick}
398403
disabled={pickRoom?.busy}
399-
variant={listFocus.index === index ? 'Primary' : 'Surface'}
404+
variant={listFocus.index === index ? 'Primary' : 'Background'}
400405
aria-pressed={listFocus.index === index}
401406
radii="400"
402407
style={{ width: '100%' }}
@@ -534,7 +539,14 @@ export function SearchWrapper({ requestClose, pickRoom }: RoomSearchModalProps)
534539
},
535540
}}
536541
>
537-
<Modal size="400" style={{ maxHeight: toRem(400), borderRadius: config.radii.R500 }}>
542+
<Modal
543+
size="400"
544+
style={{
545+
maxHeight: toRem(400),
546+
borderRadius: config.radii.R500,
547+
background: color.Background.Container,
548+
}}
549+
>
538550
<RoomSearchModal requestClose={requestClose} pickRoom={pickRoom} />
539551
</Modal>
540552
</FocusTrap>

src/app/pages/client/inbox/Inbox.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,12 @@ export function Inbox() {
9191
<Box grow="Yes" gap="300" justifyContent="Center">
9292
{!hideText ? (
9393
<Box grow="Yes">
94-
<Text size="H4" truncate>
94+
<Text
95+
size="H4"
96+
truncate
97+
align={isMobile ? 'Center' : undefined}
98+
style={{ width: '100%' }}
99+
>
95100
Inbox
96101
</Text>
97102
</Box>

src/app/pages/client/navigate/Navigate.tsx

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,13 @@
11
import { Box, Scroll, toRem, Text, color, config } from 'folds';
22
import { SquaresFour, sizedIcon } from '$components/icons/phosphor';
3-
import {
4-
Page,
5-
PageContent,
6-
PageContentCenter,
7-
PageHeroSection,
8-
PageNav,
9-
PageNavHeader,
10-
} from '$components/page';
3+
import { Page, PageContent, PageContentCenter, PageNav, PageNavHeader } from '$components/page';
114
import { useEffect, useState } from 'react';
125
import { ScreenSize, useScreenSizeContext } from '$hooks/useScreenSize';
136
import { useSetting } from '$state/hooks/settings';
147
import { settingsAtom } from '$state/settings';
158
import { SidebarResizer } from '../sidebar/SidebarResizer';
169
import { useSetAtom } from 'jotai';
1710
import { isResizingSidebarAtom } from '$state/isResizingSidebar';
18-
import { ListMagnifyingGlassIcon } from '@phosphor-icons/react';
1911
import { RoomSearchModal } from '$features/navigate';
2012
import { UserQuickTools } from '../sidebar/UserQuickTools';
2113

@@ -41,24 +33,26 @@ export function Navigate() {
4133
position: 'relative',
4234
width: toRem(curWidth),
4335
borderRight: 'solid',
44-
borderColor: color.SurfaceVariant.ContainerLine,
36+
borderColor: color.Background.ContainerLine,
4537
borderWidth: `0 ${config.borderWidth.B300} 0 0`,
38+
background: color.Background.Container,
4639
}}
4740
>
4841
<PageNav>
4942
<PageNavHeader size="600">
5043
<Box grow="Yes" gap="300" justifyContent="Center">
5144
{!hideText ? (
5245
<Box grow="Yes">
53-
<Text size="H4" truncate align="Center">
54-
Navigate
46+
<Text size="H4" truncate>
47+
Inbox
5548
</Text>
5649
</Box>
5750
) : (
5851
sizedIcon(SquaresFour, '200', { filled: true })
5952
)}
6053
</Box>
6154
</PageNavHeader>
55+
6256
<SidebarResizer
6357
setCurWidth={setCurWidth}
6458
sidebarWidth={roomSidebarWidth}
@@ -74,17 +68,26 @@ export function Navigate() {
7468
</Box>
7569
)}
7670
<Page>
77-
<Box grow="Yes">
71+
<Box grow="Yes" direction="Column" style={{ background: color.Background.Container }}>
72+
<PageNavHeader size="600">
73+
<Box grow="Yes" gap="300" justifyContent="Center">
74+
{!hideText ? (
75+
<Box grow="Yes">
76+
<Text size="H4" align="Center" truncate style={{ width: '100%' }}>
77+
Navigate
78+
</Text>
79+
</Box>
80+
) : (
81+
sizedIcon(SquaresFour, '200', { filled: true })
82+
)}
83+
</Box>
84+
</PageNavHeader>
7885
<Scroll hideTrack visibility="Hover">
7986
<PageContent style={{ height: '100%', paddingBottom: '0' }}>
8087
<PageContentCenter style={{ height: '100%' }}>
81-
<PageHeroSection style={{ height: '100%', paddingBottom: '0' }}>
82-
<Box direction="Column" gap="100" alignItems="Center" style={{ height: '100%' }}>
83-
{sizedIcon(ListMagnifyingGlassIcon, '600')}
84-
<Text size="H1"> Navigate </Text>
85-
<RoomSearchModal />
86-
</Box>
87-
</PageHeroSection>
88+
<Box direction="Column" gap="100" alignItems="Center" style={{ height: '100%' }}>
89+
<RoomSearchModal isMobile />
90+
</Box>
8891
</PageContentCenter>
8992
</PageContent>
9093
</Scroll>

0 commit comments

Comments
 (0)