Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORY] How has the Constitution of India changed over the years? #1

Open
3 of 18 tasks
dharashah410 opened this issue Mar 2, 2019 · 12 comments
Open
3 of 18 tasks

[STORY] How has the Constitution of India changed over the years? #1

dharashah410 opened this issue Mar 2, 2019 · 12 comments
Assignees
@dharashah410 @ishitachaudhary
Labels
Law

Comments

@dharashah410
Copy link
Member

Ideation

  • Decide story pitch with domain experts
    • Does the story idea add value?
    • Is data available?

Prepare

  • Data collection and cleaning
  • Story insight
  • Get story reviewed from domain experts (Is there even a story here?)

Plan

  • Structure of the story
  • Design the visualization
  • Get story reviewed from domain experts (Is the story plan making sense?)

Execute

  • Code the visualization
  • Write the essay
  • Get story reviewed from domain experts

Publish

  • Prepare social media images
  • Publish
    • Post on site
    • Post on Instagram
    • Post on Facebook
    • Post on Twitter
@dharashah410 dharashah410 changed the title Annotate constitution of India with amendments Annotate Constitution of India with Amendments Mar 2, 2019
@dharashah410 dharashah410 changed the title Annotate Constitution of India with Amendments How has the constitution of India changed over the years? Mar 3, 2019
@dharashah410 dharashah410 changed the title How has the constitution of India changed over the years? How has the Constitution of India changed over the years? Mar 3, 2019
@dharashah410 dharashah410 transferred this issue from another repository Mar 10, 2019
@dharashah410 dharashah410 changed the title How has the Constitution of India changed over the years? [STORY] How has the Constitution of India changed over the years? Mar 10, 2019
@dharashah410
Copy link
Member Author

dharashah410 commented Mar 17, 2019 •
edited
Loading

Timeline

  • Add tooltip on hover of each amendment
  • The brush selection has shifted after adding tooltip. It needs margin adjustments @GauravB159
  • Amendment tooltip on right side of the timeline is getting cut @GauravB159
  • On load last 2 amendments (latest ones 102 and 103) pre-selected on timeline, rest others dulled out @GauravB159
  • Remove unload scrolling effect and directly show last 2 amendment @GauravB159
  • Make timeline sync when navigating through left and right arrows @GauravB159
  • When 2 lines are selected using brush, dull out the other lines @GauravB159
  • Highlight the PM in circle based on brush selection. Dull out rest of the circles by making images as greyscale @GauravB159
  • Filter amendments based on brush selection @GauravB159

Track changes view

  • Add mini map besides each amendment @GauravB159
  • Can we just lazy load the amendments which are been selected rather than rendering all of them?

Table of contents

  • Add article title, part number and part title in the JSON
  • Change the dummy text with actual values for above 3 keys
  • Part titles should align with article numbers. Remove duplicate title names
  • Show article numbers in the table of content
  • Sort the articles number (alphanumeric sort)
  • Add tooltip on hover of each article
  • Add heatmap based on how many times the article has been changed
  • Show part title on left of article box instead of right
  • Add navigation arrows as carousel
  • Add up and down arrows in TOC. Hide scroll in the div
  • Click on up/down arrow of table of content should be in sync with the amendments of the constitution @GauravB159
  • On scroll of any 1 amendment, the rest should scroll @GauravB159

@dharashah410
Copy link
Member Author

dharashah410 commented Mar 19, 2019 •
edited by GauravB159
Loading

@GauravB159 We need to make following changes in Minimap

  • Make the red and green lines in the minimap clickable
  • Increase the height of red and green lines a bit so that it's clickable.
  • The minimap needs to go near border right of each container / where the scroll appears. Remove the minimap box that you have added.

@dharashah410
Copy link
Member Author

dharashah410 commented Mar 21, 2019 •
edited
Loading

Bugs @GauravB159

  • When I scroll to the bottom of the page and then select something on timeline, the page scrolls up
  • On click of up and down arrow, the down arrow stops working after I go up and down 2 times
  • The brush is not snapping. I am able to select more than 2 amendment.
  • The sync scroll is working for first block only. It should work for both the amendment blocks
  • Right now sync is one way ie TOC impacts amendment blocks. Make it work 2 way i.e TOC boxes get highlighted based on scrolling of amendment
  • Scrolling using TOC not synced up. To recreate: Click on 22 in TOC and check Original and Amendment 1. Click on 22 again.

@SamhitaWiki SamhitaWiki deleted a comment from GauravB159 Mar 22, 2019
@dharashah410
Copy link
Member Author

dharashah410 commented Mar 22, 2019 •
edited
Loading

@ishitachaudhary

  1. Convert document to HTML using https://wordhtml.com/ tool
  • Remove all inline styles by selecting this button in the tool

Screenshot 2019-03-22 at 11 26 44 AM

  • Replace all &lt; with "<"
  • Replace all &gt; with ">"
  • Replace all &ldquo; and &rdquo; with double quotes (")
  • Remove all <strong> and </strong> tags
  • Replace all <li> with <p> tags
  • Remove all <ol> tags and add the number in start attribute in the <li> tag preceding it
  • Add attribute data-scrollto="article-article_no" to all <p> tags where article number is mentioned
  • Remove all blank spaces i.e &nbsp;
  1. Write down the process you are following to create the tags (which sites are you referring, creating back up tags etc) so that when new amendments are added in future other person can take it forward. Take a small screen capture video demonstrating the process.

@dharashah410
Copy link
Member Author

dharashah410 commented Mar 23, 2019 •
edited
Loading

  • Add single handle vertical slider (with scroll icon image for handle) on the left of the brick wall and remove up and down arrow navigation. The up/down interaction will now be shifted to dragging of slider @GauravB159
  • Show years in timeline based on width available. Rest of the years will be shown on navigation @GauravB159
  • Amendment 97 <span style=“font-size: 11px; color: gray;”>compared against Amendment 96
  • Move the < and > arrows to the sides of the timeline
  • Move the text parts to right side of the brick wall
  • Change normal text colour in the constitution as black
  • Increase size of PM’s picture similar to Mac OS’s Dock’s icon magnification (https://www.youtube.com/watch?v=liZuWpIwLEo see from minute 1)
  • Media Queries — if size drops then show only 1 amendment instead of 2
  • Media Queries — if size drops then compress timeline and show only the PMs who are currently selected
  • Test if the visualisation is touch compatible on iPad
  • Next we should implement this for mobile

@dharashah410
Copy link
Member Author

dharashah410 commented Mar 26, 2019 •
edited by GauravB159
Loading

Bugs:

  • When I quickly drag it downwards, the scroll happens but when I quickly drag it upwards, it doesnt scroll up. I think drag end event is not getting detected @GauravB159
  • On dragging circle, the up/down image position also changes
  • The slider line should not be seen on top of circle. It should always stay behind

@dharashah410
Copy link
Member Author

dharashah410 commented Mar 27, 2019 •
edited
Loading

  • Implement the algorithm 1yr = 10 px for timeline (irrespective of width available)@GauravB159
  • The sync scrolling on blocks stopped working. Scroll on one block is not scrolling other blocks, toc and slider @GauravB159
  • Scroll animation not working in Safari @GauravB159
  • Set the left position of the amendment block so that only last amendment is seen on load. (for mobile) @GauravB159
  • Slider does not move on click of TOC (both in desktop and mobile) @GauravB159
  • Touch on TOC box not working on mobile (all browsers)
  • Remove text "compared against"

@dharashah410
Copy link
Member Author

dharashah410 commented Mar 28, 2019 •
edited
Loading

Mobile issues

  • Highlight/ Select only 1 amendment line for mobile in timeline @GauravB159
  • Scrolling of block does not scroll slider and TOC (all browsers) @GauravB159
  • Show hide "overlay-div" on click of "menu-icon". Right now it just shows on click on icon but doesn't hide it back @GauravB159
  • Show TOC as overlay on mobile
  • Show TOC on deep press of the slider icon. Remove hamburger icon @GauravB159
  • Once the TOC comes as an overlay, the user can scroll scrolling through TOC via deep press and scroll @GauravB159
  • TOC disappears few seconds after the deep press on slider icon is released @GauravB159
  • Reduce height of the blocks to fit everything in one screenful @GauravB159

Desktop issues

  • Can you reduce space on right side of the svg-container? 2020 should touch the box (shared screenshot on slack) @GauravB159

@dharashah410
Copy link
Member Author

dharashah410 commented Apr 3, 2019 •
edited
Loading

  • When user deep presses on the scroll icon, the TOC will come on top of slider icon. @GauravB159
  • When I deep press and scroll (while the deep press is on), the TOC highlight will scroll and content in blocks will scroll accordingly. Here, TOC itself starts acting like a slider. @GauravB159
  • In mobile, when I navigate through left and right arrows, the blocks are not getting properly left scroll @GauravB159

@dharashah410
Copy link
Member Author

dharashah410 commented Apr 4, 2019 •
edited by GauravB159
Loading

Mobile view

  • In mobile, the scroll icon should be aligned with the block bottom. Right now it’s ending little bit up for the last article 35 @GauravB159
  • Add transition/ animation when TOC comes and goes on deep press. @GauravB159
  • Load entire viz with an overlay and call to action button at centre. @GauravB159
  • On click of CTA button, show entire viz in modal window with all interactivity. On click of back button, load the initial view with overlay and CTA button again @GauravB159
  • In mobile mode, is it possible I show PM photos in circle above the axis and lines below the axis. Basically, exchange the position of what it is right now just for mobile view. @GauravB159
  • Add labels(part titles) besides article box. Right now its display none. @GauravB159

Testing

  • Test if it works on Microsoft Edge, Firefox, Safari, Chrome @GauravB159
  • Test if it works on various devices and screen sizes (android and iPhone) @GauravB159

Content

  • Add content for all amendments @GauravB159
  • Integrate acts data along with the amendment

Later

  • Handle scenario where 2 amendments were made on same date
  • Can we add Voronoi for amendment tooltip?
  • Mobile: scrolling of block lags and doesn't go fast

@dharashah410
Copy link
Member Author

UI

  • Add smokey effect on left hand side of the TOC in mobile mode
  • On scroll of the TOC, scale the current TOC box. Eg: if size of box is 48px by 30px. It will become 70px by 45px and the font size of the article number in the box will increase

@dharashah410
Copy link
Member Author

dharashah410 commented Apr 11, 2019 •
edited by GauravB159
Loading

@GauravB159 Can you mark issues which are resolved?

Device: MacBook Air

Browser: Safari (Version 12)

  • Image of Morarji Desai not loading
  • Transition of timeline is not working

Browser: Firefox (Version 66.0.2)

  • White bar above Samhita title in header
  • Slider icon looks very sharp
  • Height of brush is larger than height of timeline
  • Transition of timeline is not working
  • Scroll of blocks is not smooth

Device: HP Laptop

Browser: Microsoft Edge

  • Viz not loading at all, spread operator does not work in Microsoft Edge. We should transpile all code

Device: Asus ZenFone Max Pro M1 (Android)

Browser: Google Chrome

  • Modal is lightly visible on initial load
  • Loading time is very slow

Browser: Firefox

  • White bar above Samhita title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dharashah410 dharashah410

@ishitachaudhary ishitachaudhary

Labels
Law
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dharashah410 @ishitachaudhary