drivers/compression: fix decompress ioctl #6894
Conversation
Add a break statement to the COMPIOC_DECOMPRESS case in comp_ioctl. This fix ensures proper handling of decompression requests. Signed-off-by: seokhun-eom <[email protected]>
| return -EINVAL; | ||
| } | ||
| ret = decompress_block(comp_info->output_buffer, &comp_info->output_size, comp_info->input_buffer, &comp_info->input_size); | ||
| if (ret == ENOMEM) { |
There was a problem hiding this comment.
error return valuse must be negative.
Could you please check return values of decompress_block and change to negative?
There was a problem hiding this comment.
In the decompress_block function the return of ENOMEM indicates that the output buffer was insufficient, resulting in only a portion of the data being decompressed while the remainder remained compressed.
In the LZMA algorithm this scenario is designed to return OK, whereas the MINIZ algorithm returns a Z_BUF_ERROR.
Would it be appropriate to modify this to return an error instead?
| if (ret == ENOMEM) { | ||
| bcmpdbg("Output buffer allocated is not sufficient\n"); | ||
| } | ||
| break; |
There was a problem hiding this comment.
it's not related to this pr but please check code line where return just ERROR, it is wrong. each of ioctl should return one of errno.
There was a problem hiding this comment.
Thank you for review. I'll make another PR for it.
There was a problem hiding this comment.
I made a new PR from your comment.
#6911
| if (ret == ENOMEM) { | ||
| bcmpdbg("Output buffer allocated is not sufficient\n"); | ||
| } | ||
| break; |
There was a problem hiding this comment.
it's not related to this pr but please check code line where return just ERROR, it is wrong. each of ioctl should return one of errno.
6 participants
Add a break statement to the COMPIOC_DECOMPRESS case in comp_ioctl.
This fix ensures proper handling of decompression requests.