Flake8 (Azure#7695)

* ignore line break after binary operator

* fixed local variable never used

* faulty escape sequence

Author: williexu

Diff for: .flake8

@@ -7,6 +7,7 @@ ignore =
     F401,  # imported but unused, too many violations, to be removed in the future
     F811,  # redefinition of unused, to be removed in the future
     C901   # code flow is too complex, too many violations, to be removed in the future
+    W504   # line break after binary operator effect on readability is subjective
 exclude = 
     azure_bdist_wheel.py
     build

Diff for: bin/extract-loc.py

@@ -27,7 +27,7 @@
     for path in ROOT.rglob('*.py'):
         with open(str(path), 'r', encoding='utf-8') as f:
             content = f.read()
-        for m in re.finditer('[^\w_]_\(("(.+)"|\'(.+)\')\)', content):
+        for m in re.finditer(r'[^\w_]_\(("(.+)"|\'(.+)\')\)', content):
             print('# From', path, ':', m.span()[0], file=f_out)
             print('KEY:', m.group(2) or m.group(3), file=f_out)
             print(m.group(2) or m.group(3), file=f_out)

Diff for: src/azure-cli-core/azure/cli/core/commands/arm.py

@@ -644,7 +644,7 @@ def handler(args):
                         raise
                 else:
                     raise
-            except Exception as ex:  # pylint: disable=broad-except
+            except Exception:  # pylint: disable=broad-except
                 progress_indicator.stop()
                 raise
 

Diff for: src/command_modules/azure-cli-eventgrid/azure/cli/command_modules/eventgrid/tests/latest/test_eventgrid_commands.py

@@ -15,7 +15,7 @@ def __init__(self):
         self.event_subscription_base_endpoint = "https://eventgridclilivetest.azurewebsites.net/api/HttpTriggerCSharp1"
         try:
             self.event_subscription_endpoint = os.environ['A01_EVENTGRID_ENDPOINT']
-        except Exception as e:
+        except Exception:
             self.event_subscription_endpoint = self.event_subscription_sanitized_endpoint
 
 

Diff for: src/command_modules/azure-cli-monitor/azure/cli/command_modules/monitor/validators.py

@@ -61,7 +61,7 @@ def _validate_weekly_recurrence(namespace):
                 namespace.recurrence = valid_recurrence[delimiter]['validator'](namespace)
             except CLIError as ex:
                 raise CLIError('{} invalid usage: {}'.format(ex, usage))
-        except KeyError as ex:
+        except KeyError:
             raise CLIError('invalid usage: -r {{{}}} [ARG ARG ...]'.format(','.join(valid_recurrence)))
 
 

Diff for: src/command_modules/azure-cli-resource/azure/cli/command_modules/resource/tests/2017_03_09_profile/test_resource.py

@@ -597,7 +597,7 @@ def test_managedappdef(self, resource_group):
             'adn': self.create_random_name('testappdefname', 20),
             'addn': self.create_random_name('test_appdef', 20),
             'ad_desc': 'test_appdef_123',
-            'uri': 'https:\/\/testclinew.blob.core.windows.net\/files\/vivekMAD.zip',
+            'uri': 'https://testclinew.blob.core.windows.net/files/vivekMAD.zip',
             'auth': '5e91139a-c94b-462e-a6ff-1ee95e8aac07:8e3af657-a8ff-443c-a75c-2fe8c4bcb635',
             'lock': 'None'
         })
@@ -690,7 +690,7 @@ def test_managedapp(self, resource_group):
             'adn': 'testappdefname',
             'addn': 'test_appdef_123',
             'ad_desc': 'test_appdef_123',
-            'uri': 'https:\/\/wud.blob.core.windows.net\/appliance\/SingleStorageAccount.zip',
+            'uri': 'https://wud.blob.core.windows.net/appliance/SingleStorageAccount.zip',
             'auth': '5e91139a-c94b-462e-a6ff-1ee95e8aac07:8e3af657-a8ff-443c-a75c-2fe8c4bcb635',
             'lock': 'None',
             'sub': self.get_subscription_id()

Diff for: src/command_modules/azure-cli-resource/azure/cli/command_modules/resource/tests/latest/test_resource.py

@@ -740,7 +740,7 @@ def test_managedappdef(self, resource_group):
             'adn': self.create_random_name('testappdefname', 20),
             'addn': self.create_random_name('test_appdef', 20),
             'ad_desc': 'test_appdef_123',
-            'uri': 'https:\/\/testclinew.blob.core.windows.net\/files\/vivekMAD.zip',
+            'uri': 'https://testclinew.blob.core.windows.net/files/vivekMAD.zip',
             'auth': '5e91139a-c94b-462e-a6ff-1ee95e8aac07:8e3af657-a8ff-443c-a75c-2fe8c4bcb635',
             'lock': 'None'
         })
@@ -833,7 +833,7 @@ def test_managedapp(self, resource_group):
             'adn': 'testappdefname',
             'addn': 'test_appdef_123',
             'ad_desc': 'test_appdef_123',
-            'uri': 'https:\/\/wud.blob.core.windows.net\/appliance\/SingleStorageAccount.zip',
+            'uri': 'https://wud.blob.core.windows.net/appliance/SingleStorageAccount.zip',
             'auth': '5e91139a-c94b-462e-a6ff-1ee95e8aac07:8e3af657-a8ff-443c-a75c-2fe8c4bcb635',
             'lock': 'None',
             'sub': self.get_subscription_id()