Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement smarter auth source identification for AnsibleTower #178

Open
JacobCallahan opened this issue Jan 16, 2023 · 1 comment
Open

Comments

@JacobCallahan
Copy link
Member

@rplevka had a great suggestion in #177 for a better way to determine which auth sources an AAP instance supports.

an unauthenticated request to <aap_server>/api/ resource
returns the following info:

{
"description": "AWX REST API",
"current_version": "/api/v2/",
"available_versions": {
"v2": "/api/v2/"
},
"oauth2": "/api/o/",
"custom_logo": "",
"custom_login_info": "",
"login_redirect_override": ""
}
Wouldn't it be better if broker fetched the custom_login_info value and display it as warning if set?
This way, we could keep the login-specifics to the individual provider instances instead of hardocding stuff.

We should evaluate this and see if we can use this instead of the current version implemented in that PR.

@JacobCallahan
Copy link
Member Author

this could possibly be attempted by creating an instance of the unauthenticated API and running api.get() to get the custom_login_info. Though we'd need to have a standard telling us what's supported and what isn't.

In [12]: api.get()
Out[12]: 
{
    "description": "AWX REST API",
    "current_version": "/api/v2/",
    "available_versions": {
        "v2": "/api/v2/"
    },
    "oauth2": "/api/o/",
    "custom_logo": "",
    "custom_login_info": "",
    "login_redirect_override": ""
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant