Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watched spending: don't import to watching wallet #312

Open
Kexkey opened this issue Oct 11, 2023 · 3 comments
Open

Watched spending: don't import to watching wallet #312

Kexkey opened this issue Oct 11, 2023 · 3 comments

Comments

@Kexkey
Copy link
Collaborator

Kexkey commented Oct 11, 2023

We don't need to import an address from the spending wallet to the watching wallet to be able to watch it; every address of the node's wallets will trigger a walletnotify action.

Currently we systematically import a watched address to the watching wallet even if it's a spending address, so we have a lot of addresses in both wallets for no gains.

@phillamy
Copy link
Contributor

Added optional callback urls to getnewaddress so CN can add a watch in a single call. The clients won't have to call getnewaddress followed by a watch request of this newaddress anymore

@Kexkey
Copy link
Collaborator Author

Kexkey commented Mar 24, 2024

Did you also remove the importaddress to the watching wallet when trying to watch a spending wallet address?

@phillamy
Copy link
Contributor

Can't find those changes locally. Maybe changed my mind also : let the caller do the 2 calls and wrap those 2 calls into something called watchNewBitcoinAddress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants