Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer elixir versions #37

Open
Linuus opened this issue Jul 19, 2019 · 4 comments · May be fixed by #67
Open

Newer elixir versions #37

Linuus opened this issue Jul 19, 2019 · 4 comments · May be fixed by #67

Comments

@Linuus
Copy link

Linuus commented Jul 19, 2019

The readme says that Scenic only works with Elixir 1.7 and OTP 21.

I can’t find any issues here on github on what’s not working on later versions. Is there such a list somewhere?

@Linuus
Copy link
Author

Linuus commented Jul 19, 2019

I just installed scenic and generated a nerves app. Now I get this warning: warning: the dependency :scenic requires Elixir "~> 1.8" but you are running on v1.7.4. So I guess the Readme here is wrong then?

@Eiji7
Copy link

Eiji7 commented Jul 19, 2019

@Linuus If we take a look at mix.exs in scenic repository then we would find:

defmodule Scenic.Mixfile do
  # …

  @elixir_version "~> 1.8"
  # …

  def project do
    [
      # …
      elixir: @elixir_version,
      # …
    ]
  end
  # …
end

Which means that scenic requires elixir in at least 1.8 version.

Then we can take a look at history of that file. and finally we would see:

back to 1.8
boydm committed on 10 Mar

turn off build_embedded
boydm committed on 10 Mar

try building under 1.7
boydm committed on 10 Mar

so to elixir 1.8
boydm committed on 10 Mar…

Which gives as a hint that scenic not longer compiles under elixir in version 1.7. Most probably it uses some new elixir API or there were a bug in elixir fixed in version 1.8.

Looks like that scenic would require elixir in version 1.8 and it won't be changed.

@boydm Looks like we would need to update some parts of code (like templates in examples) + documentation.

@boydm
Copy link
Collaborator

boydm commented Jul 19, 2019

Of course... I don't exactly remember what the reason for going to 1.8 was...

@Linuus
Copy link
Author

Linuus commented Jul 20, 2019

Cool :)

Just to be clear, this is the part that confused me: https://github.com/boydm/scenic_new/blob/master/README.md#erlangelixir-versions

axelson added a commit to axelson/scenic_new that referenced this issue Sep 25, 2023
- Make it more clear that the two scenic.new commands are used separately
- Make the version of Elixir and Erlang/OTP required more obvious (fixes ScenicFramework#37)
- Add a link to `scenic_driver_local`
@axelson axelson linked a pull request Sep 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants