-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fixes for MTK changes #1186
base: master
Are you sure you want to change the base?
Conversation
This is probably never going to pass tests with the change in semantics for |
We can also no longer rely on |
Let's see how this turns out. If something like what you suggest is really changing it would be one of the largest changes to Catalyst ever, probably after moving to maps as inputs to problems. Would probably take ages to figure out all the implications. |
@TorkelE let's just work in this PR to try to get tests working again. I've handled the conservation law constants getting scalarized issue, and locally gotten tests in reactionsystem.jl working again. |
TODO:
|
I had some updates locally to sort out the new parameters, but there are quite a few recent MTK issues that are hard-blocking us so I stopped a bit: |
OK, I'll get as much fixed here as I can modulo those issues and then plan to merge. FYI, take a look at the changes to |
Updates conservation laws to work with new
remake
version.