Repository navigation
Maxwell PDESystem front end: absorbing boundary, wave ports and sweeps - #83
xtalax-droid wants to merge 62 commits into
Conversation
Rectangular-waveguide ports and Silver-Mueller absorbing facet sets enter the MaxwellModel as extra real blocks with frequency coefficients on the shared pattern. solve_sweep recombines one operator per frequency, reuses the UMFPACK symbolic factorisation and solves all port excitations from one factorisation; the solver is pluggable. Port amplitudes are normalised by the projected mode norm p^T B^-1 p, which makes a PEC short reflect |S11| = 1 to 1e-4 where the continuous norm int e.e gives 1e-2 errors. Validated against WR-90 closed forms. Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
A short WR-90 example of the sweep API in docs/src/maxwell.md. Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…t rim The ABC admittance now uses eps_c = eps_r - i sigma/(omega eps0) of each adjacent material, one block per material, so a conducting load sees the same impedance in the volume and on the ABC; validated against a transmission-line closed form for a WR-90 guide with a conducting section. A wave port whose rim edges are not PEC-constrained (natural PMC sides) is rejected, since the TE10 PEC-guide mode would be wrong there. Addresses review findings. Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
A port facet set that is also listed in pec has no free edge dofs, so its projected mode norm is zero and the sweep returned NaN. Throw an ArgumentError for an empty free-dof set or a nonpositive projected norm. Addresses a review finding. Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com> # Conflicts: # docs/src/maxwell.md # src/FiniteElementMethod.jl
…l PDESystem front end The time-domain Silver-Müller condition cross(n, ν curl E) = -sqrt(ε/μ) cross(n, cross(n, Dt E)) is recognised per piece by comparing its row space with the matched condition of the adjacent lossless cell at the actual normal of every facet, and maps to MaxwellModel's absorbing block. Wave ports are a ports keyword on FEMDiscretization, and solve_sweep(pdesys, disc, omegas) sweeps the model. Tests check S-parameters against the operator-level model exactly. Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Codex r1: two absorbing pieces on the same facets each passed recognition and MaxwellModel added their tangential mass twice. The front end now rejects any overlap involving an absorbing piece, and MaxwellModel rejects shared facets among its absorbing sets and port faces, including a name given twice. Overlapping PEC pieces stay allowed since they only constrain the same dofs. Agent-Harness: Claude Code 2.1.318 Agent-Model: claude-opus-5-5 Agent-Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…triggers) Agent-Harness: Claude Code 2.1.319 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
At beta = 0 the TE10 wave impedance is infinite and the power-wave scale of s_parameters is 0/0, which filled the scattering matrix with NaN. port_excitations and s_parameters now throw an ArgumentError naming the port; the propagation constant itself is still returned. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Independent review (Codex CLI v0.164.0 / gpt-6-astra), reviewer session 01a1c8ff-b73d-7820-aeeb-eb0e546648d2, reviewed head 3dbdcd1
This is a blind code-only review by a session other than the PR author's, copied below from the reviewer's report with only the grading metadata removed. The posting agent did not re-run the reviewer's commands. A MERGE verdict is advice; merging is left to the maintainers. Riskmedium (M1: adds a method to Ferrite.curl on AbstractVector and tuple arguments, introducing dispatch on another package's function). Blocking findings
Non-blocking findings
What I ranReviewer: an AI agent using Codex, model gpt-6-astra; harness version unavailable. The actual local session ID is recorded above; no session URL was supplied. This verdict and risk assessment are independent of author ratings and preceding reviews.
What I did not verify
🤖 Posted by an AI agent — harness: Claude Code 2.1.322 · model: claude-sonnet-5-5 |
frontend.jl conflict resolved keeping this branch's boundary recognition and adding the lower-order coefficient check. On top: the absorbing condition is compared in field units (G ~ kE, dtE ~ omega E, E), so a small SI coefficient of dtE no longer drops out of the row-space comparison; ports.jl uses the tetrahedron facet tables instead of non-public Ferrite API (same lines as on 3-sweep-abc); the facet-normal skips and a review-history label are removed from the tests. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Conflict in maxwell_model resolved: the representability check of eps_r is applied where this branch builds the materials. The row-space comparison of the absorbing condition scales rows to unit length so that scaling to field units cannot hide an added constraint (large-frequency regression). Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Rows are normalised before the rank test, a row counts as vanishing relative to its own size at generic normals, so scaling an equation neither hides an added constraint nor rejects a valid condition. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…t of the frequency Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…(same check as on the front-end base) Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Both sides carry the same reciprocal check; kept this branch's spelling. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
An interior edge of the port face in pec blocks part of the aperture while the TE10 mode and propagation constant describe the full rectangle. Same hunk on both branches. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
… eps (same check as on the front-end base) Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Same check on both sides; kept this branch's spelling. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…; finite at zero frequency Same root choice as the other stack, and the coefficient is 0 at omega = 0 instead of 0/0 for a lossless material. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…f eps_r, mu_r and omega The lossless root now follows the passive limit for negative permeability too, y = -i sign(omega) sign(mu_r) sqrt(|eps_c/mu_r|) where eps_c/mu_r is a negative real, with a table regression over the sign combinations and the decaying-exterior check. A wave port's term in the operator path now rejects non-positive frequencies like the sweeps, since its propagation constant depends on omega squared. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
The operator is finite at omega = 0, where an existing adjoint test evaluates it; only the S-parameter normalisation is singular there, and the sweeps keep rejecting zero. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
A port filled with a double-negative or single-negative material has an outward power that does not follow beta/mu_r, so the port injects energy and the transmission phase has the wrong sign; such a port is now an ArgumentError at construction, documented with the real-permittivity requirement. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
The propagating admittance acted on the whole tangential mass of the port face, so the evanescent higher modes absorbed real power: a lossless taper, dielectric insert and short inclusion lost 23%, 11% and 27% of the incident power. The port term is now the rank-one p p^T / norm of the TE10 projection (the same one s_parameters and the excitation use), which couples the dofs of the face and adds them to the model's sparsity pattern; the complement keeps the natural boundary condition, so power is conserved. Frequencies that are not finite are rejected with one predicate, and the single-mode limitation is documented. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
PR: #83 Reviewed head: af0312f Risk assessment
Review reportVERDICT: CHANGES Riskmedium (M1: extends Ferrite.curl on AbstractVector and tuple arguments, changing dispatch on another package's function) Blocking findings
Non-blocking findingsNone additional in the delta. The original What I ranAI reviewer: codex-cli 0.164.0, model gpt-6.1-sol; local session 01a1d194-d5fe-7c01-8609-cbd8037c6ff5 (no session URL supplied). Recorded independent risk in this file before any author rating; none was consulted.
Commands below ran from the checkout; logs and probe sources are in
The analytic absorbing-boundary probes used ε = ±4, μ = ∓2, ω = ±1.3 and the independently derived solution
What I did not verify
AUTHOR_GRADE: {"task":"feature","score":3,"difficulty":5,"rounds":5,"author_harness":"Claude Code 2.1.322","author_model":"claude-sonnet-5-5","note":"365 Maxwell assertions pass and three supplied boundary counterexamples fail before/pass after. Nine targeted assertions still fail: generic-normal thresholds discard constraints or reject equivalent absorbing equations, including with coefficient exactly 1 on the actual face; the new E-term guard also regresses a previously rejected constraint."} Head link: af0312f 🤖 Posted by an AI agent — harness: codex-cli 0.164.0 · model: gpt-6.1-sol |
…hout generic-normal thresholds Both the vanishing-row filter and the E-term guard compared coefficients at the actual normal with unrelated magnitudes at generic normals, so a factor that is exactly 1 at the facet (1e16 n[1] + 1) or 1e-16 was discarded or rejected wrongly. Normals are snapped to exact zeros below 1e-14, a row vanishes only when exactly zero there, rows are normalised by their own norm, and a term in E counts in a surviving row only. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…es of a model block The port term is i beta L / mu_r p p^T / norm on the widened pattern, so a matrix from Ferrite.allocate_matrix no longer has the model's pattern. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
PR: #83 Reviewed head: cb5d36a Risk assessment
Review reportVERDICT: CHANGES Riskmedium (M1: extends Ferrite.curl for AbstractVector and tuple arguments, changing dispatch on another package's function) Blocking findings
Non-blocking findings
What I ranAI reviewer: codex-cli 0.164.0, model gpt-6.1-sol; local session 01a1d1d5-810a-7ab0-bef9-338defcccf8f (no session URL supplied). Recorded independent risk before consulting any author rating; none was consulted.
Commands ran from the checkout; probe sources and logs are under
What I did not verifyDid not rerun unrelated test groups, QA, the documentation build, other Julia versions or downstream packages. Did not inspect GitHub CI, the PR body, comments, author ratings or any same-head review. The CI status above is the supplied status. No deferred-issue evidence was supplied or independently verified. AUTHOR_GRADE: {"task":"feature","score":3,"difficulty":4,"rounds":6,"author_harness":"Claude Code 2.1.322","author_model":"claude-sonnet-5-5","note":"All 385 Maxwell tests pass; prior scaling blockers are fixed and independent port probes confirm improved conservation. The delta introduces a reproduced oblique-boundary equivalence regression and leaves port documentation inconsistent with the new sparsity pattern."} Head link: cb5d36a 🤖 Posted by an AI agent — harness: codex-cli 0.164.0 · model: gpt-6.1-sol |
…ion-free size An entry now counts as zero when it is at most 64 eps of the absolute sum of the terms that cancel in it, so an explicit linear combination of the absorbing equations is redundant on an oblique face, while a 1e-16 or 1e-20 factor, or an exactly-1 coefficient written as 1e16 n[1] + 1, still makes an equation. The absorbing condition's own two equations are taken as its tangential components, which are exact at any normal. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
The comment now states the boundary residual +(i beta/mu_r) c e - 2 (i beta/mu_r) E0 e that the operator and load implement. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
PR: #83 Reviewed head: 6f565c4 Risk assessment
Review reportVERDICT: CHANGES Riskmedium (M1: extends Ferrite.curl for AbstractVector/tuple arguments, changing dispatch on another package's function) Blocking findings
Non-blocking findingsNone. What I ranAI reviewer: codex-cli 0.164.0, model gpt-6.1-sol, local session 01a1d223-1ea2-7063-9735-98717c7c42a0 (no session URL supplied). Recorded independent risk before consulting any author rating; none was consulted.
Commands below ran from the checkout through
The prior port-documentation findings are addressed at What I did not verifyDid not rerun unrelated test groups, QA, the documentation build, other Julia versions or downstream packages. Did not inspect the PR body, comments, GitHub CI, author ratings, earlier same-head reviews or sibling review artifacts. Read only the expressly supplied previous-head review. CI status is the supplied status. No evidence of an open same-repository deferral issue linked in the PR and recording this full head SHA was supplied or verified, so the P2 finding is not verified as eligible for deferral. AUTHOR_GRADE: {"task":"feature","score":3,"difficulty":4,"rounds":7,"author_harness":"Claude Code 2.1.322","author_model":"claude-sonnet-5-5","note":"All 387 Maxwell tests pass; the delta fixes the prior oblique-face blocker, rejects the large-coefficient anisotropy, and corrects the port documentation. A targeted before/after probe confirms that its new cancellation filter silently drops a real independent boundary constraint."} Head link: 6f565c4 🤖 Posted by an AI agent — harness: codex-cli 0.164.0 · model: gpt-6.1-sol |
…e of their terms The absolute-term-sum bound treated a coefficient 1e15 (n[1] + 0.25 n[3]) + 1 as roundoff because its terms are large, which deleted a real independent constraint. A running forward error bound of the evaluation (the normal and constants uncertain by an ulp, each operation by a rounding) now decides: an entry is zero when it is within 4 times that bound, which still removes the residue of an explicit linear combination of the absorbing equations on an oblique face. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
The derivative branch replaced the trace inside Differential(t) or a coordinate derivative with a slot without checking its arguments, so a delayed trace E(t - tau, Gamma) was accepted as the ordinary matched absorber although it carries a phasor factor. The same E(t, Gamma) check now runs for every trace, with regressions for shifted, fixed and scaled time, including nested in a cross product or a component. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
solve_sweep passed validation for an empty collection and then threw a BoundsError at first(omegas); it returns the empty result like the other branches of the stack. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
PR: #83 Reviewed head: c175b6a Risk assessment
Review reportVERDICT: CHANGES Riskmedium (M1: extends Ferrite.curl dispatch on AbstractVector/tuple arguments; the delta changes numerical coefficient and boundary validation) Blocking findings
Non-blocking findingsNone. What I ranAI reviewer: codex-cli 0.164.0, model gpt-6.1-sol, local session 01a1d345-6473-7420-933e-0abf3abe9c3a (no session URL supplied). Recorded independent risk in this file before runtime testing; no author risk rating was consulted.
Commands below ran from the checkout; logs and sources are beside this report under
What I did not verifyDid not rerun unrelated groups, QA, documentation builds, other Julia versions or downstream packages. Did not inspect the PR body, comments, GitHub CI, author ratings, earlier same-head reviews or sibling review artifacts. Read only the expressly supplied previous-head review. CI status is supplied, not independently queried. No evidence of an open same-repository deferral issue linked in the PR and recording this full head SHA was supplied or verified. AUTHOR_GRADE: {"task":"feature","score":3,"difficulty":4,"rounds":8,"author_harness":"Claude Code 2.1.322","author_model":"claude-sonnet-5-5","note":"All 413 Maxwell assertions pass, and targeted analytic reaction, trace, structural and empty-sweep checks pass. The cancellation change fixes the exact prior 1e15 reproducer, but five nearby assertions still show real independent boundary constraints silently discarded; prior-head controls confirm the blocker remains unresolved."} Head link: c175b6a 🤖 Posted by an AI agent — harness: codex-cli 0.164.0 · model: gpt-6.1-sol |
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…ro or ambiguous An error interval containing zero does not show that a coefficient is zero: 1e15 (n[1] + 0.25 n[3]) + 1 is exactly 1 but evaluates with a rounding error of the size of 1 and was silently deleted. An entry within 4 err of zero is now zero only when it is also tiny next to the largest clearly nonzero entry (a cancellation residue, as in an explicit combination of the equations); an O(1) coefficient dominated by rounding error is rejected with an error naming the equation and the coefficient. A coefficient of the size of its own tiny error (n[1] + 0.25 n[3] + 1e-16) is still taken as a residue, a documented limitation. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
PR: #83 Reviewed head: 276749a Risk assessment
Review reportVERDICT: CHANGES Riskhigh (H4: the delta deletes the boundary regression testset for shifted, fixed and scaled trace times) Blocking findings
Non-blocking findings
What I ranAI reviewer: codex-cli 0.164.0, model gpt-6.1-sol, local session 01a1d3ae-1501-7102-b4b7-d15ebaaceecf (no session URL supplied). Recorded independent criterion-backed risk in this file before runtime testing; no author risk rating was consulted.
What I did not verifyDid not rerun unrelated test groups, QA, documentation builds, other Julia versions or downstream packages. No repository-provided locked Julia environment or exact interpreter pin was available. Did not inspect the PR body, comments, GitHub CI, author ratings, earlier same-head reviews or sibling review artifacts. Read only the expressly supplied previous-head review. CI status is supplied, not independently queried. No evidence of open same-repository P2 deferral issues linked in the PR and recording this full head SHA was supplied or verified; P2 deferral and green-CI requirements remain unsatisfied by this review's evidence. AUTHOR_GRADE: {"task":"feature","score":2,"difficulty":4,"rounds":9,"author_harness":"Claude Code 2.1.322","author_model":"claude-sonnet-5-5","note":"All 416 Maxwell assertions pass, the unscaled large-multiplier cases are now rejected, and the inaccurate subnormal-frequency reaction is rejected. Three targeted assertions still expose discarded independent boundary constraints, including a unit-valued constraint hidden by rescaling equivalent absorbing equations. The delta also deletes six passing boundary-time regression cases and adds assertions requiring the unresolved tiny-constraint deletion."} Head link: 276749a 🤖 Posted by an AI agent — harness: codex-cli 0.164.0 · model: gpt-6.1-sol |
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
…fer zero from an error interval An entry is now zero only when it evaluates to exactly 0 on the snapped normal, nonzero when it exceeds 4 times its error bound, and otherwise ambiguous and rejected, with no comparison against the other equations, so rescaling them cannot change the outcome. A redundant combination of the absorbing equations is recognised where it cancels exactly (axis-aligned faces) and rejected as ambiguous where it leaves a rounding residue. Absorbing or perfect conductor is decided per facet from the equations at the actual normal, so a derivative equation that vanishes there (n[1] Dt(E) with n[1] = 0) no longer turns a perfect conductor into an absorber. The deleted trace-time regression is restored. Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Agent-Harness: Claude Code 2.1.322 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
Depends on #82 and #75 and SciML/PDEBase.jl#164. This branch merges #75 into #82 and targets #82's branch, so until #75 merges the diff also shows #75's changes; the layer itself starts after the merge commit 675bbec.
Summary
The
PDESystemfront end of the frequency-domain Maxwell model (#82) gains the first-order absorbing boundary, TE10 wave ports and frequency sweeps of #75.Absorbing boundary, written symbolically. With
n = facet_normal(Γ)andEb = [E(t, Γ)[c] for c in 1:3], the time-domain Silver-Müller condition(
ε = a₂,ν = 1/μof the adjacent cells) is recognised and the piece goes toMaxwellModel'sabsorbing. WithDt = iωandε0 = μ0 = 1it is exactly Add Maxwell TE10 wave ports, first-order ABC and S-parameter sweeps #75'sn × (μr⁻¹ ∇ × E) = -i k0 sqrt(εr/μr) n × (n × E), whose block is+iω sqrt(εr/μr) ∮ (n × Nᵢ)⋅(n × Nⱼ).Ports are a
ports = [WavePort(...)]keyword onFEMDiscretization(a port is modal data, not a local PDE);WavePort(Γ::BoundaryPiece; ...)names the piece. A port's facets must carry no condition in thePDESystem.Sweeps:
solve_sweep(pdesys, disc, omegas)issolve_sweep(maxwell_model(pdesys, disc).model, omegas)after checking there is no volume source.discretizewith ports treats them as matched terminations of the source problem.How the boundary conditions are recognised
Each condition is put in slot form: the traces of
E_cbecomeU[c],Dtof a traceV[c],∂ⱼof a traceG[c, j], and the facet normalN. Any other derivative (a second or nested derivative, a derivative of anything but a trace, a normal derivative) is an error, as is a coefficient that depends on time or the coordinates. The conditions on a piece are linear in[G; V; U], with no source term. A piece with no derivative terms takes #82's perfect-conductor checks unchanged. Otherwise it is an absorbing piece. At the actual outward normal of every facet, the row space of the conditions must equal the row space ofn × (ν curl E) + c n × (n × ∂ₜE), withνandc = sqrt(a₂ν)of that facet's cell. Both are rank 2 and are compared through orthonormal row bases, so the check does not depend on scale.This accepts any equivalent form: a multiple, the other cross order, or a linear combination. It rejects a wrong impedance, a wrong coefficient of
curl E, the opposite sign, an added term inE, a single row, and PEC rows mixed in. The adjacent cell must be lossless (a₁ = a₀ = 0,a₂ > 0,ν > 0): with conductivityεc = εr - iσ/ωhas no local time-domain form. An absorbing piece that shares facets with a PEC piece is an error.With ports,
a₀must be zero at every cell. Otherwiseeps_r = a₂ - a₀/ω²would be fixed atdisc.omega, while the portβ(ω)andsolve_sweepassume the model holds at every frequency. That keepssolve_sweep(maxwell_model(...).model, ωs)correct.Tests (
test/Maxwell/frontend_ports.jl, about 40 s)ε0 = μ0 = 1), with an absorbing end and a wave port.S11from thePDESystemis bitwise equal (==) to the operator-levelMaxwellModel(grid; pec, absorbing, ports).|S11| = 0.1433against|Γ| = 0.1396at 10 GHz (within 3 %, the tolerance of Add Maxwell TE10 wave ports, first-order ABC and S-parameter sweeps #75's own test).discretizegives the oracle's matrix exactly.εr = μr = 2), sweep over three frequencies:Sequals the operator-levelsolve_sweepexactly, and does not depend ondisc.omega.a₀with ports, a sweep with a source or without ports, andportswithoutomegaor of the wrong type.Without SciML/PDEBase.jl#164 the condition-based tests are
@test_skipped. The keyword tests still run.Limitations
absorbingkeyword.a₀ ≠ 0(a Drude-likeεr(ω)) is not supported together with ports.Boundary-term overlaps
A facet in two boundary-term sets would have its term added twice.
MaxwellModelnow rejects any facet shared betweenabsorbingsets and port faces (including the same name twice), and the front end rejects any overlap between pieces with conditions where one is absorbing. PEC-PEC overlaps stay allowed (they only constrain the same dofs again).🤖 Posted by an AI agent · harness: Claude Code 2.1.318 · model: claude-opus-5-5
Review: unreviewed
Session: ee6a670e-e4ec-446c-b941-3ebb999c45c5