-
-
Notifications
You must be signed in to change notification settings - Fork 41
refac: build on LuxCore #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Some naming things to decide:
|
|
Not really sure about the Downgrade failure here, if I run |
|
This should be more or less ready to go, there are some things I need to smooth out but its current state it's far, far better compared to the current version 0.11.4. Pending Downgrade solution I would merge this and improve eventual minor issues directly on main. After merging I will need to address some minor init breaking changes before tagging 0.12, which is essentially a v1.0 candidate ping @ChrisRackauckas |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This PR refactors ReservoirComputing.jl to build on LuxCore. Closes #206, #202, and #191