Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add battery example to NonlinearProblem + Updates for NonlinearSolve v3 #792

Merged
merged 16 commits into from
Dec 12, 2023
Merged

Add battery example to NonlinearProblem + Updates for NonlinearSolve v3 #792

merged 16 commits into from
Dec 12, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 8, 2023

No description provided.

@ChrisRackauckas ChrisRackauckas mentioned this pull request Dec 9, 2023
Closed
@avik-pal
Copy link
Member Author

avik-pal commented Dec 9, 2023

@ChrisRackauckas what's up with the agents? Most of the recent builds seem stalled

@ChrisRackauckas
Copy link
Member

It's just backed up

@ChrisRackauckas
Copy link
Member

It ran, failed.

@ChrisRackauckas
Copy link
Member

SciML/Sundials.jl#437

@avik-pal
Copy link
Member Author

Oh no... It is due to the manifest being in 1.10 😞

@avik-pal
Copy link
Member Author

@TorkelE do you know what is up with the PrettyTables error?

@TorkelE
Copy link
Member

TorkelE commented Dec 10, 2023

Not sure, cannot actually see the error

@avik-pal
Copy link
Member Author

The battery example is running fine
image

@ChrisRackauckas
Copy link
Member

We should really get subheaders in there.

@avik-pal
Copy link
Member Author

I am confused by the segfault here https://buildkite.com/julialang/scimlbenchmarks-dot-jl/builds/1871#_

@ChrisRackauckas
Copy link
Member

Retriggered and praying.

@avik-pal
Copy link
Member Author

@ChrisRackauckas do pdfs not get uploaded as artifacts?

@ChrisRackauckas
Copy link
Member

I think you'd need to modify

SciMLBenchmarks.jl/.buildkite/run_benchmark.yml

Line 35 in 466a462

- markdown/**/figures/*.png

@avik-pal
Copy link
Member Author

image

Not sure how to get this done, but I want the script to upload all pdfs generated in the directory (cc maybe @staticfloat)

@ChrisRackauckas
Copy link
Member

Why pdf and not something like SVG?

@avik-pal
Copy link
Member Author

same problem right, the yml file needs to be updated. Either works for me. I want to have something that I can put in a paper, anything but jpg/pngs

@ChrisRackauckas
Copy link
Member

Yeah just put svg right next to anything in the CI scripts that does .png and it should work.

@staticfloat
Copy link
Contributor

I'm on vacation right now, but @thazhemadam can also help with this, he knows how.

@staticfloat
Copy link
Contributor

@avik-pal do you want me to change the .yml to upload .svgs as well as .pdfs?

@avik-pal
Copy link
Member Author

yeah that would be great

@avik-pal
Copy link
Member Author

That was a weird fix, but atleast it is not segfaulting now 🤷‍♂️

@avik-pal
Copy link
Member Author

It worked 🎉. Though we need to look into Problem 6, that is the only one which none of the solvers, even non-julia ones can solve

@ChrisRackauckas ChrisRackauckas merged commit b5c1e2a into SciML:master Dec 12, 2023
1 check failed
@avik-pal avik-pal deleted the ap/update_battery branch December 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avik-pal @ChrisRackauckas @TorkelE @staticfloat @MarcBerliner