Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBC File Integration Tests #3748

Closed
trexfeathers opened this issue Jun 26, 2020 · 4 comments
Closed

LBC File Integration Tests #3748

trexfeathers opened this issue Jun 26, 2020 · 4 comments
Labels
Stale A stale issue/pull-request Type: Enhancement

Comments

@trexfeathers
Copy link
Contributor

After discussion with @nhsavage during #3743, we believe it would be beneficial to have one or two integration tests for parsing LBC files - to be stored in SciTools/iris-test-data.

@nhsavage will be sourcing these files in due course. It is important that these files:

  • represent typical LBC files that we expect Iris to work with
  • will not take too long to process

See SciTools/iris-test-data, and try running any existing Iris integration tests that use iris-test-data files, for an idea of appropriate files.

@nhsavage
Copy link
Contributor

actually I was wrong - there is already 1 integration test for LBCs. Data is at https://github.com/SciTools/iris-test-data/tree/master/test_data/FF/lbc and the test is here

@nhsavage
Copy link
Contributor

Looking in detail at this file, many of the headers are wrong. It also will have been created with the legacy code makeBC not the more modern CreateBC (when this file was uploaded 18 Nov 2014, CreateBC had not been released (27 Feb 2015). Therefore an LBC file with some valid metadata should be included, possibly incliding a 360 day calendar and a variable resolution file.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

@github-actions github-actions bot added the Stale A stale issue/pull-request label Nov 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

This stale issue has been automatically closed due to a lack of community activity.

If you still care about this issue, then please either:

  • Re-open this issue, if you have sufficient permissions, or
  • Add a comment pinging @SciTools/iris-devs who will re-open on your behalf.

@github-actions github-actions bot closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale A stale issue/pull-request Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants