Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: switch to maintained fork and update to v1.75 #6261

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

Daviteusz
Copy link
Contributor

@Daviteusz Daviteusz commented Oct 19, 2024

About this PR

Original version Innounp (can be used up to InnoSetup 6.1)
Updated Unicode version Innounp-1 (can be used up to InnoSetup 6.3)

Innounp-1 supports Inno Setup versions 2.0.7 to 6.3.1

In my opinion, the new version should be used by default, and the old version should be placed in the versions repository.

What should I do?

Update innounp and try install your software again.

scoop update innounp

This PR fixes these issues:

Extras

fix ScoopInstaller/Extras#14242, fix ScoopInstaller/Extras#14235, fix ScoopInstaller/Extras#14126, fix ScoopInstaller/Extras#14255, fix ScoopInstaller/Extras#14256, fix ScoopInstaller/Extras#14120, fix ScoopInstaller/Extras#14115, fix ScoopInstaller/Extras#14259, fix ScoopInstaller/Extras#14264, fix ScoopInstaller/Extras#14265, fix ScoopInstaller/Extras#14271, fix ScoopInstaller/Extras#14272, fix ScoopInstaller/Extras#14281, fix ScoopInstaller/Extras#14285, fix ScoopInstaller/Extras#14289, fix ScoopInstaller/Extras#14290, fix ScoopInstaller/Extras#14292, fix ScoopInstaller/Extras#14296, fix ScoopInstaller/Extras#14306, fix ScoopInstaller/Extras#14310, fix ScoopInstaller/Extras#14317, fix ScoopInstaller/Extras#14318, fix ScoopInstaller/Extras#14321, fix ScoopInstaller/Extras#14329, fix ScoopInstaller/Extras#14335, fix ScoopInstaller/Extras#14338, fix ScoopInstaller/Extras#14363, fix ScoopInstaller/Extras#14367, fix ScoopInstaller/Extras#14377, fix ScoopInstaller/Extras#14383

Main

fix #6201, fix #6147, fix #6158, fix #6141, fix #6291, fix #6294, fix #6295, fix #6296

Copy link
Contributor

Your changes do not pass checks.

innounp

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Daviteusz Daviteusz force-pushed the patch-1 branch 2 times, most recently from 7f80e3b to f911381 Compare October 19, 2024 14:21
Copy link
Contributor

Your changes do not pass checks.

Invalid manifests

  • innounp

@Daviteusz Daviteusz force-pushed the patch-1 branch 2 times, most recently from 91c90da to 2779328 Compare October 19, 2024 14:31
Copy link
Contributor

Your changes do not pass checks.

innounp

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Copy link
Contributor

Your changes do not pass checks.

innounp

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Daviteusz Daviteusz changed the title [email protected]: switch to maintained fork and update to 1.73.json [email protected]: switch to maintained fork and update to v1.73 Oct 20, 2024
@Daviteusz
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

innounp

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Daviteusz Daviteusz changed the title [email protected]: switch to maintained fork and update to v1.73 [email protected]: switch to maintained fork and update to v1.75 Nov 1, 2024
@HUMORCE
Copy link
Member

HUMORCE commented Nov 1, 2024

Although ScoopInstaller/Scoop#6028 use versions/innounp-unicode as the preferred Inno Unpacker, but the guide is missing, and it is not even added to the main bucket as an important dependency of Scoop.

This PR solves a lot of issues about inno-setup's decompress error.

Once original innounp is updated, we can use some special methods to get it back.

/cc @niheaven

@HUMORCE HUMORCE merged commit ca0aa61 into ScoopInstaller:master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment