From 795673a0604b565543867fe7837744bb2271383d Mon Sep 17 00:00:00 2001 From: z-Fng <54583083+z-Fng@users.noreply.github.com> Date: Wed, 17 Sep 2025 16:21:17 -0400 Subject: [PATCH 1/2] fix(checkver): Prevent variable leakage from previous iteration --- bin/checkver.ps1 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bin/checkver.ps1 b/bin/checkver.ps1 index 33a4449488..e7551fcf0c 100644 --- a/bin/checkver.ps1 +++ b/bin/checkver.ps1 @@ -285,6 +285,9 @@ while ($in_progress -gt 0) { continue } + # Prevent variable leakage from previous iteration + $page, $match = $null + if ($url) { $ms = New-Object System.IO.MemoryStream $ms.Write($result, 0, $result.Length) From 0ef4c81f8efdba416b45f3d97af44fd79a386df4 Mon Sep 17 00:00:00 2001 From: z-Fng <54583083+z-Fng@users.noreply.github.com> Date: Wed, 17 Sep 2025 16:50:18 -0400 Subject: [PATCH 2/2] Apply suggestions from code review --- bin/checkver.ps1 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/checkver.ps1 b/bin/checkver.ps1 index e7551fcf0c..21e5bf2757 100644 --- a/bin/checkver.ps1 +++ b/bin/checkver.ps1 @@ -274,6 +274,9 @@ while ($in_progress -gt 0) { $expected_ver = $json.version $ver = $Version + # Prevent per-iteration state leakage + $page, $match, $matchesHashtable = $null + if (!$ver) { if (!$regexp -and $replace) { next "'replace' requires 're' or 'regex'" @@ -285,9 +288,6 @@ while ($in_progress -gt 0) { continue } - # Prevent variable leakage from previous iteration - $page, $match = $null - if ($url) { $ms = New-Object System.IO.MemoryStream $ms.Write($result, 0, $result.Length)