Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for allowUnlimitedContractSize flag #16

Open
mds1 opened this issue Apr 23, 2020 · 1 comment
Open

Remove need for allowUnlimitedContractSize flag #16

mds1 opened this issue Apr 23, 2020 · 1 comment

Comments

@mds1
Copy link
Contributor

mds1 commented Apr 23, 2020

In test-environment.config.js we currently set allowUnlimitedContractSize: true. Without this flag, deployment of EndaomentFactory fails with an out of gas error.

Investigate why and make the required changes so this is not needed.

Relevant portions of the docs from the ganache README are below:

"allowUnlimitedContractSize": boolean - Allows unlimited contract sizes while debugging (NOTE: this setting is often used in conjuction with an increased gasLimit). By setting this to true, the check within the EVM for contract size limit of 24KB (see EIP-170) is bypassed. Setting this to true will cause ganache-core to behave differently than production environments. (default: false; ONLY set to true during debugging).

@apbendi
Copy link
Member

apbendi commented Apr 25, 2020

One possibility is we're genuinely over the 24 KB limit, but this would be surprising to me. Another possibility is we're hitting some kind of pathological compiler case that's producing bytecode way bigger than it needs to be. Maybe running with the optimizer would help. Will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants