-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming Grant Mecahnics #17
Conversation
I had a similar issue and created #16 for it. If you have any details to add that would probably be a good place to put them |
Some questions/thoughts:
Otherwise, all tests passed! 🥳 Other general question—in the tests I noticed you do things like |
8a4cdfc
to
c6aa21a
Compare
Special methods for submission & processing of proposals
* Rename contract & contract file * Replace all error messages and comments throughout the contract
Great feedback. Thanks!
Good call. Done.
Good question. So the new OZ contracts all use the "initializer" pattern, which broke Moloch's assumptions around the
Don't think so either. Removed.
Agreed don't think we need it.
Ahh yes good call, will do this.
No major tradeoffs I'm aware of. In fact if my understand of JavaScript is correct they're functionally the same. Not sure why I used |
OK! I've made changes for all your suggestions and rebased to your (now merged) branch. If it looks good to you, feel free to merge! |
Basic functionality for issuing & revoking streaming grants via Sablier.
Aside from needing some cleanup & cleaning up the commit history I think this is good to go. I also had to increase gas limits (not sure if it's real or a bug) but I set them to super high numbers. Need to investigate this.
closes #6
closes #7
closes #11