From 4c8249dec60ce1daab620c3743ea0773b591329e Mon Sep 17 00:00:00 2001 From: garyghayrat Date: Wed, 10 Jul 2024 16:45:26 -0400 Subject: [PATCH 1/3] Sign over Base chainId --- umbra-js/src/classes/Umbra.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/umbra-js/src/classes/Umbra.ts b/umbra-js/src/classes/Umbra.ts index 7271dfab..a5b42980 100644 --- a/umbra-js/src/classes/Umbra.ts +++ b/umbra-js/src/classes/Umbra.ts @@ -598,7 +598,7 @@ export class Umbra { const baseMessage = 'Sign this message to access your Umbra account.\n\nOnly sign this message for a trusted client!'; // prettier-ignore // Append chain ID if not mainnet to mitigate replay attacks - const { chainId } = await this.provider.getNetwork(); + const chainId = 8453; // Base; const message = chainId === 1 ? baseMessage : `${baseMessage}\n\nChain ID: ${chainId}`; // Get 65 byte signature from user using personal_sign From 93c8b8dff488663cbf41c0da55ce25ad4998a434 Mon Sep 17 00:00:00 2001 From: garyghayrat Date: Wed, 10 Jul 2024 16:55:30 -0400 Subject: [PATCH 2/3] add type number --- umbra-js/src/classes/Umbra.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/umbra-js/src/classes/Umbra.ts b/umbra-js/src/classes/Umbra.ts index a5b42980..687d7f25 100644 --- a/umbra-js/src/classes/Umbra.ts +++ b/umbra-js/src/classes/Umbra.ts @@ -598,7 +598,7 @@ export class Umbra { const baseMessage = 'Sign this message to access your Umbra account.\n\nOnly sign this message for a trusted client!'; // prettier-ignore // Append chain ID if not mainnet to mitigate replay attacks - const chainId = 8453; // Base; + const chainId = 8453; // Base chainId; const message = chainId === 1 ? baseMessage : `${baseMessage}\n\nChain ID: ${chainId}`; // Get 65 byte signature from user using personal_sign From cf795340458cdccde034f7e58d7629843063818a Mon Sep 17 00:00:00 2001 From: garyghayrat Date: Wed, 10 Jul 2024 16:59:49 -0400 Subject: [PATCH 3/3] Show correct message --- umbra-js/src/classes/Umbra.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/umbra-js/src/classes/Umbra.ts b/umbra-js/src/classes/Umbra.ts index 687d7f25..1183bd27 100644 --- a/umbra-js/src/classes/Umbra.ts +++ b/umbra-js/src/classes/Umbra.ts @@ -599,7 +599,7 @@ export class Umbra { // Append chain ID if not mainnet to mitigate replay attacks const chainId = 8453; // Base chainId; - const message = chainId === 1 ? baseMessage : `${baseMessage}\n\nChain ID: ${chainId}`; + const message = `${baseMessage}\n\nChain ID: ${chainId}`; // Get 65 byte signature from user using personal_sign const userAddress = await signer.getAddress();