Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused code / opportunity for Filter Contract #17

Open
ScotterC opened this issue Apr 26, 2023 · 3 comments
Open

Unused code / opportunity for Filter Contract #17

ScotterC opened this issue Apr 26, 2023 · 3 comments

Comments

@ScotterC
Copy link
Owner

Currently we have some very nice unused code, Filter which would do a good job of validating filter params. It's not currently in use right now but would be with a small change here

The reason is that the Filter class doesn't pass it's filter attributes into the Query class and therefore the values get lost silently. This test can be easily modified to see what's happening. Modifying the filter class, probably with an attribute could resolve the issue.

@pyrabbit
Copy link
Contributor

I could help with this @ScotterC . Do you have any additional comments since the creation of this issue?

@ScotterC
Copy link
Owner Author

@pyrabbit that'd be great!
Since this was introduced, I feel a bit mixed on having the dependency on dry-struct/dry-validation. They're nice to have to ensure a valid Filter object but if you find that they're not doing any real heavy lifting then I'd be up for scrapping it.

@pyrabbit
Copy link
Contributor

@ScotterC Thanks for the feedback.. This evening I'll work on trying to put something together for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants