You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we have some very nice unused code, Filter which would do a good job of validating filter params. It's not currently in use right now but would be with a small change here
The reason is that the Filter class doesn't pass it's filter attributes into the Query class and therefore the values get lost silently. This test can be easily modified to see what's happening. Modifying the filter class, probably with an attribute could resolve the issue.
The text was updated successfully, but these errors were encountered:
@pyrabbit that'd be great!
Since this was introduced, I feel a bit mixed on having the dependency on dry-struct/dry-validation. They're nice to have to ensure a valid Filter object but if you find that they're not doing any real heavy lifting then I'd be up for scrapping it.
Currently we have some very nice unused code, Filter which would do a good job of validating filter params. It's not currently in use right now but would be with a small change here
The reason is that the Filter class doesn't pass it's filter attributes into the Query class and therefore the values get lost silently. This test can be easily modified to see what's happening. Modifying the filter class, probably with an
attribute
could resolve the issue.The text was updated successfully, but these errors were encountered: