Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that results are consistent across different architectures and machines #30

Open
ianhinder opened this issue Apr 29, 2020 · 2 comments
Labels
CoronaBICI RSE To be done by an RSE

Comments

@ianhinder
Copy link
Contributor

In particular, check that the RNG is portable. The code seems to use rand. The results of this are not portable; e.g. macOS' std C library has a different algorithm to glibc. Possibly the C++ RNGs are more portable; I'm not sure.

@ianhinder ianhinder added CoronaBICI RSE To be done by an RSE labels Apr 29, 2020
@richardreeve
Copy link
Member

richardreeve commented May 2, 2020

I had to update Distributions.jl a while ago so that all distributions could handle a first argument RNG to make it thread safe. So we should be using that everywhere, such as here, and we set up RNGs here as MersenneTwisters, so unless the code is inconsistent between architectures for that RNG, we should be okay I think?

@ianhinder
Copy link
Contributor Author

@richardreeve, you replied to a CoronaBICI issue. Need to get per-label notifications working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CoronaBICI RSE To be done by an RSE
Projects
None yet
Development

No branches or pull requests

2 participants