Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "\n" with std::endl in all logging output #73

Open
ianhinder opened this issue May 1, 2020 · 0 comments
Open

Replace "\n" with std::endl in all logging output #73

ianhinder opened this issue May 1, 2020 · 0 comments
Labels
CoronaBICI Functionality New capabilities of the code RSE To be done by an RSE

Comments

@ianhinder
Copy link
Contributor

Logging output is using an explicit "\n" to end the line. This leaves the output buffered. This should be changed to std::endl, because that includes automatic line buffering. Currently, when the output is directed to a file, it only updates once the buffer is full, which is annoying, as you think it has hung. There are explicit calls to "flush" in bici.cc which are presumably designed to get around this.

Note that there are 136 occurrences of "\n" in the code, so this should be done when nobody is working on large-scale changes, to avoid conflicts.

$ grep '\\n' bici.cc header/*.h|wc -l
     136
@ianhinder ianhinder added RSE To be done by an RSE CoronaBICI Functionality New capabilities of the code labels May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CoronaBICI Functionality New capabilities of the code RSE To be done by an RSE
Projects
None yet
Development

No branches or pull requests

1 participant