Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to readfile functions #79

Open
sdl1 opened this issue May 4, 2020 · 0 comments
Open

Small improvements to readfile functions #79

sdl1 opened this issue May 4, 2020 · 0 comments
Labels
RSE To be done by an RSE Simulation.jl Starter Issue

Comments

@sdl1
Copy link
Member

sdl1 commented May 4, 2020

  • Informative error if specified file(s) don't exist
  • Reduce duplicated code, e.g. call readfile(file::String, xmin, xmax, ymin, ymax) from within readfile(file::String)
@sdl1 sdl1 added Simulation.jl RSE To be done by an RSE Starter Issue labels May 4, 2020
@AlexRobson AlexRobson self-assigned this May 5, 2020
@AlexRobson AlexRobson removed their assignment Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RSE To be done by an RSE Simulation.jl Starter Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexRobson @sdl1