Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File API close to C++ binding #752

Open
andyb96247 opened this issue Sep 10, 2020 · 1 comment · May be fixed by ScottishCovidResponse/data_pipeline_api#109
Open

Add File API close to C++ binding #752

andyb96247 opened this issue Sep 10, 2020 · 1 comment · May be fixed by ScottishCovidResponse/data_pipeline_api#109
Assignees
@andyb96247
Labels
C++ data pipeline api - C++ binding

Comments

@andyb96247
Copy link

Currently no access-*.yaml file is created for the c++ binding.

The cause is that the binding is not leading to the File API close method being called. In python, the API would be accessed via "with" which would call the appropriate "exit" method. The C++ binding doesn't currently do this. Hence, either the "pybind11" equivalent of "with" needs investigating, or call the close method directly from the destructor.

The latter will be the approach taken.
@andyb96247 andyb96247 self-assigned this Sep 10, 2020
@andyb96247 andyb96247 linked a pull request Sep 10, 2020 that will close this issue
Open
@kzscisoft
Copy link

kzscisoft commented Mar 19, 2021 •
edited
Loading

I have merged this into https://github.com/ScottishCovidResponse/cpp-data-pipeline. I will keep the issue open in case we still want to merge in Andy's MR into the data_pipeline_api repo too.

@kzscisoft kzscisoft added the C++ label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyb96247 andyb96247

Labels
C++ data pipeline api - C++ binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add in close to destructor ScottishCovidResponse/data_pipeline_api
2 participants
@kzscisoft @andyb96247