fix: refactor stream variants #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TroyKomodo
temporarily deployed
to
lint-test-build
GitHub Actions
Inactive
|
Ill fix ci after approve from 1 more reviewer |
lennartkloock
approved these changes
May 29, 2023
Completes #86 bullet point 4 This change refactors how we store the stream variants and also sets up the transcoder for unit tests and cleans up the way transcoder invokes ffmpeg.
TroyKomodo
force-pushed
the
troy/transcoder
branch
from
c7eccfa
to
4a7486e
Compare
TroyKomodo
temporarily deployed
to
lint-test-build
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Completes #86 bullet point 4
This change refactors how we store the stream variants and also sets up the transcoder for unit tests and cleans up the way transcoder invokes ffmpeg.
Previously we did some jank way of having variants and then variants that reference other variants which was really messy.
Now we have variants and transcode states. Variants can either reference 1 or more transcode states.
The HLS manifest is then created to comprise these changes
In this manifest we transcode both
AACaudio andOPUSaudio, Opus is smaller and better quality than AAC so it should be preferred if the client supports Opus.Types of changes
What types of changes does your code introduce to Scuffle?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.