Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with AFrame 1.3.0 #1

Open
Utopiah opened this issue Nov 22, 2022 · 2 comments
Open

Compatibility with AFrame 1.3.0 #1

Utopiah opened this issue Nov 22, 2022 · 2 comments

Comments

@Utopiah
Copy link

Utopiah commented Nov 22, 2022

Hi, I just tried with AFrame stable current (1.3.0) and received 2 error messages :

  • The Components object is deprecated. It will soon be removed.
  • Uncaught TypeError: THREE.Geometry is not a constructor

THREE.Geometry was removed in r125 and I can see that https://github.com/chandlerprall/ThreeCSG is still maintained (even though without touching the code itself for 4 years) so I'm wondering what would be best here :

  • patch here
  • upstream patch to ThreeCSG then including again as you did (knowing this kind of modification is rare)
  • upstream patch to ThreeCSG then including ThreeCSG from e.g npm
@Utopiah
Copy link
Author

Utopiah commented Nov 22, 2022

Alternatively https://github.com/gkjohnson/three-bvh-csg seems quite active.

@Stremps
Copy link

Stremps commented Dec 11, 2024

Hello, there. I made some changes to Baltes' code and managed to implement it in newer version of A-frame in a very simple way, but not perfect. If you want to try it, here is the link: https://github.com/Stremps/A-frame-CSG-Operations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants