Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaded Multisig Descriptors are wiped at Main Menu #527

Open
3rdIteration opened this issue Feb 17, 2024 · 3 comments
Open

Loaded Multisig Descriptors are wiped at Main Menu #527

3rdIteration opened this issue Feb 17, 2024 · 3 comments

Comments

@3rdIteration
Copy link
Contributor

Expected Behavior
Once loaded (either through scanning a descriptor from the main menu or loading one through the address exporer) a multi-sig descriptor is automatically used to verify multisig transaction outputs.

Actual Behavior
Multisig Outputs are not automatically verified unless the descriptor is loaded each time a transaction is signed.

Exploration
As it stands, the current multisig descriptor is wiped each time the user returns to the main menu.

@newtonick
Copy link
Collaborator

The behavior of forgetting previously scan descriptors is intentional. This said I'm personally open to changing this behavior to store descriptors in a single session (during power on state) if done in an intuitive way. I like your idea of changing "Next" to "Skip Verification" in the UI.

@3rdIteration
Copy link
Contributor Author

Yea I'll fix the PR I brought to just tweak the language and add a warning.

How exactly it behaves is less important than making sure that it's both consistent and obvious what is going on.

@3rdIteration
Copy link
Contributor Author

Ah actually I see what happened there, I merged the dev branch, so I have just wiped those commits, as well as revert the change to keep it and the PR is back to the warning only now.

New PR is here: #533

Whether you think the dire warning is appropriate is neither here nor there, but this is a situation that can result in loss of funds, so the use of a "Dire Warning" here seems appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants