Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit all modules to send the entities they need to be extracted as part of the module info #54

Open
MennaCC opened this issue Jul 1, 2017 · 1 comment
Open

Edit all modules to send the entities they need to be extracted as part of the module info #54

MennaCC opened this issue Jul 1, 2017 · 1 comment
Assignees
@m-anwr @n1amr @MahmoudRizk
Labels
ml/nlp modules

Comments

@MennaCC
Copy link
Contributor

MennaCC commented Jul 1, 2017 •
edited
Loading

Scenario

  • A module specifies the entities it needs to be parsed using the Enum EntityType
  • The entities needed by that module are parsed from the json holding the module info, and stored in the db when the module is installed
  • Parser gets them @runtime after the sentence is entered by the user and returns a dict of [entity_type: [value, text in the original sentence before being parsed]

The Enum mentioned earlier is in branch Alfred45
@MennaCC
Copy link
Contributor Author

MennaCC commented Jul 4, 2017 •
edited
Loading

Edit

Entities needed by a module are parsed from json file named "needed_entities.json" that should be created in the resources folder
This json file is optional, if the module doesn't need any parsing it will run normally without it

@MennaCC MennaCC added ml/nlp and removed core labels Jul 4, 2017
n1amr added a commit that referenced this issue Jul 9, 2017
@n1amr
#54 - Send entities to modules
d746d8d
n1amr added a commit that referenced this issue Jul 9, 2017
@n1amr
#54 - Pass entities to modules
aeec151 
# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date:      Sun Jul 9 01:54:17 2017 +0200
#
# interactive rebase in progress; onto 5f5ce44
# Last command done (1 command done):
#    reword d746d8d #54 - Send entities to modules
# Next command to do (1 remaining command):
#    pick 3e2abe7 Hotfix: Workarounds for incompatibility bug between spacy and duckling
# You are currently editing a commit while rebasing branch 'master' on '5f5ce44'.
#
# Changes to be committed:
#	modified:   alfred/alfred.py
#	modified:   alfred/modules/api/a_base_module.py
#	modified:   alfred/modules/module_info.py
#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-anwr m-anwr

@n1amr n1amr

@MahmoudRizk MahmoudRizk

Labels
ml/nlp modules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@m-anwr @n1amr @MahmoudRizk @MennaCC