Issue 35 metadata lost on multiplication #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add in title or subscription what you are doing here. This is just improving our tests and no addition to any logic right? |
|
This PR indeed adds no additional logic, only a test to check whether Issue #35 is successfully resolved (plus some refactoring of test util functions). Note that this is a merge into resample-while-keeping-metadata, and that branch (with PR #23) actually contains the logic that resolves this issue (as a side effect, because I was actually addressing deeper issues there: #22 and #26). |
nhoening
approved these changes
Dec 18, 2020
Flix6x
added a commit
that referenced
this pull request
Dec 21, 2020
This PR drops support for pandas<1.1.5 and adds various tests to ensure metadata is propagated on various operations. Specific code changes: - Every constructor now calls finalize. - for_each_belief_ is no longer passed self as the df to work on. * Call finalize in all constructors to inherit metadata. Prepare tests for upcoming pandas==1.1.1 functionality: inherit metadata when resampling and grouping. * Update reference in test. Add pandas test. * Finish rebase. * Complete the ordering of BeliefSources by name. * Fix computation order. * Workaround for aggregation function when resampling. * Fix tests: - Separate tests for mean resampling and aggregate resampling. - Separate tests for temporary attributes and subclass attributes. - Test metadata propagation for groupby of subclassed DataFrames. * Update pandas dependency. Drop support for pandas<1.1.5. Bump timely-beliefs version with major release. * Prepare dtype test for empty frames. * Add comment about which pandas version fixed test_groupby_retains_metadata. * Rename downsampling function. * Simplify calls to for_each_belief. * Fix plotting integer values (int64 is not JSON serializable). * Add reference in test docs to relevant pandas issue. * Issue 35 metadata lost on multiplication (#43) This PR adds no additional logic, only a test to check whether Issue #35 is successfully resolved (plus some refactoring of test util functions). Note that this is a merge into resample-while-keeping-metadata, and that branch (with PR #23) actually contains the logic that resolves this issue (as a side effect, because I was actually addressing deeper issues there: #22 and #26). * Refactor metadata propagation checks to util function. * Add test for metadata propagation upon multiplication (GH 35). Co-authored-by: F.N. Claessen <[email protected]> Co-authored-by: Felix Claessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds no additional logic, only a test to check whether Issue #35 is successfully resolved (plus some refactoring of test util functions). Note that this is a merge into resample-while-keeping-metadata, and that branch (with PR #23) actually contains the logic that resolves this issue (as a side effect, because I was actually addressing deeper issues there: #22 and #26).