Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Curb Http Client #14121

Closed
titusfortner opened this issue Jun 11, 2024 · 3 comments
Closed

[🐛 Bug]: Curb Http Client #14121

titusfortner opened this issue Jun 11, 2024 · 3 comments

Comments

@titusfortner
Copy link
Member

What happened?

Default Http Client added separate timeout values for open and read timeouts, since that conflicted with the superclass timeout setting, we removed that setting (2965e4e)

We removed/deprecated the persistent client subclass, but not the curb client subclass. So curb client can no longer set timeouts.

How can we reproduce the issue?

Selenium::WebDriver::Remote::Http::Curb.new(timeout: 120)

Relevant log output

n/a

Operating System

n/a

Selenium version

Ruby trunk

What are the browser(s) and version(s) where you see this issue?

n/a

What are the browser driver(s) and version(s) where you see this issue?

n/a

Are you using Selenium Grid?

no

@aguspe
Copy link
Contributor

aguspe commented Jul 19, 2024

Hi @titusfortner I hope you are having a great day, I just created a PR as a bugfix to this #14285 but just a heads up I'm not fully sure if I got the right fix because I might have misunderstood something, so if you have time to review, just let me know what I can fix if something is off, thanks!

@aguspe
Copy link
Contributor

aguspe commented Aug 20, 2024

Can we consider this resolved due to the merged of #14285 @p0deje ? I'm just looking for something new to pick up and it will help me filter

@p0deje p0deje closed this as completed Aug 21, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants