Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type error for params in ApprovedRevsHandler #24

Closed
hexmode opened this issue Nov 12, 2021 · 1 comment
Closed

type error for params in ApprovedRevsHandler #24

hexmode opened this issue Nov 12, 2021 · 1 comment

Comments

@hexmode
Copy link
Member

hexmode commented Nov 12, 2021

Setup and configuration

  • SMW version: 3.1.5 (65a99ec)
  • SAR version: 0.1-alpha (8e30af0)
  • MW version: 1.34.4 (873590f)
  • DB: Percona 5.7.23-23-57-log

Issue

Seen in my exception log when jobs were running:

TypeError from line 68 of .../extensions/SemanticApprovedRevs/src/ApprovedRevsHandler.php: Argument 2 passed to SMW\ApprovedRevs\ApprovedRevsHandler::doChangeRevision() must be an instance of MediaWiki\Revision\RevisionStoreRecord or null, object given, called in .../extensions/SemanticApprovedRevs/src/Hooks.php on line 176

Looks similar to #23.
hexmode added a commit to hexmode/SemanticApprovedRevs that referenced this issue Nov 12, 2021
@hexmode
Update SAR revision usage with MW's MCR
2ff731e 
At least, a first step in that direction.

See 6af796f3e0cf3e66cd7d7e59af8445f5712d68fe

Fixes SemanticMediaWiki#24
hexmode added a commit to hexmode/SemanticApprovedRevs that referenced this issue Nov 12, 2021
@hexmode
Update SAR revision usage with MW's MCR
97a6e9e 
At least, a first step in that direction.

See wikimedia/mediawiki#6af796f3e0cf3e66cd7d7e59af8445f5712d68fe

Fixes SemanticMediaWiki#24
hexmode added a commit to hexmode/SemanticApprovedRevs that referenced this issue Nov 12, 2021
@hexmode
Update SAR revision usage with MW's MCR
b844e45 
At least, a first step in that direction.

See wikimedia/mediawiki@6af796f

Fixes SemanticMediaWiki#24
@hexmode
Copy link
Member Author

hexmode commented Nov 12, 2021

Had to get the linking right for my this...

@hexmode hexmode mentioned this issue Nov 12, 2021
Closed
2 tasks
hexmode added a commit to hexmode/SemanticApprovedRevs that referenced this issue Nov 15, 2021
@hexmode
Update SAR revision usage with MW's MCR
494f68d 
At least, a first step in that direction.

See wikimedia/mediawiki@6af796f

Fixes SemanticMediaWiki#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update SAR revision usage with MW's MCR hexmode/SemanticApprovedRevs
1 participant
@hexmode