SkinTemplateOutputPageBeforeExec hook is being deprecated

[jdlrobson]

Issue

The SkinTemplateOutputPageBeforeExec hook is being deprecated so that the skin rendering aspect of mediawiki can become more logicless. In this process I am identifying missing hooks and helping extensions migrate to more appropriate hooks (adding them if they don't exist)

https://phabricator.wikimedia.org/T60137 has further information.

Without fulling understanding the code in SemanticBreadcrumbs I see one usage however I'm not 100% sure what it's doing:
https://github.com/SemanticMediaWiki/SemanticBreadcrumbLinks/blob/master/src/HookRegistry.php#L102

Possible solution

Apologies in advance if I'm making any bad assumptions about how SemanticMediaWiki works - please correct me if that's the case!

Based on the following code, it seems that SemanticBreadcrumbs uses this hook to modify the subtitle:

SemanticBreadcrumbLinks/src/SkinTemplateOutputModifier.php

Line 65 in 9366d22

$template->data['subtitle'] .= $this->htmlBreadcrumbLinksBuilder->getHtml();

If that's the case I would recommend using OutputPage::addSubtitle in one of the OutputPage hooks e.g. OutputPageBeforeHTML

Please let me know if that doesn't make sense or is not possible for some reason. I'll be happy to help find / provide other solutions.

[UnknownSkyrimPasserby]

I made a patch for it #71, can anyone review it? Frankly speaking I don't know PHP and I don't understand how the MW/SMW engine works.