Replace wfGetDB with MediaWikiServices::getInstance()->getDBLoadBalancer()->getMaintenanceConnectionRef (#89)

* Replace wfGetDB with MediaWikiServices::getInstance()->getDBLoadBalancer()->getMaintenanceConnectionRef

* Update SqlProvider.php

* Update PageSchemas.php

* Update SqlProvider.php

* Update AppliedFilter.php

* Update psalm.xml

* Update PageSchemas.php

* Update SqlProvider.php

* Update PageSchemas.php

* Update AppliedFilter.php

Author: paladox

includes/AppliedFilter.php

@@ -152,7 +152,9 @@ public function checkSQL( $value_field ) {
 		}
 
 		$sql = "(";
-		$dbr = wfGetDB( DB_REPLICA );
+		$dbr = MediaWikiServices::getInstance()
+			->getDBLoadBalancer()
+			->getMaintenanceConnectionRef( DB_REPLICA );
 		if ( $this->search_terms != null ) {
 			$quoteReplace = ( $wgDBtype == 'postgres' ? "''" : "\'" );
 			foreach ( $this->search_terms as $i => $search_term ) {

includes/Filter.php

@@ -2,6 +2,7 @@
 
 namespace SD;
 
+use MediaWiki\MediaWikiServices;
 use SD\Sql\PropertyTypeDbInfo;
 use SD\Sql\SqlProvider;
 use SMWDIProperty;
@@ -106,7 +107,9 @@ public function getTimePeriodValues(): PossibleFilterValues {
 		$possible_dates = [];
 		$property_value = $this->escapedProperty();
 		$date_field = PropertyTypeDbInfo::dateField( $this->propertyType() );
-		$dbw = wfGetDB( DB_PRIMARY );
+		$dbw = MediaWikiServices::getInstance()
+				->getDBLoadBalancer()
+				->getMaintenanceConnectionRef( DB_PRIMARY );
 		list( $yearValue, $monthValue, $dayValue ) = SqlProvider::getDateFunctions( $date_field );
 		$fields = "$yearValue, $monthValue, $dayValue";
 		$datesTable = $dbw->tableName( PropertyTypeDbInfo::tableName( $this->propertyType() ) );
@@ -234,7 +237,9 @@ public function getTimePeriodValues(): PossibleFilterValues {
 	public function getAllValues(): PossibleFilterValues {
 		$possible_values = [];
 		$property_value = $this->escapedProperty();
-		$dbw = wfGetDB( DB_PRIMARY );
+		$dbw = MediaWikiServices::getInstance()
+				->getDBLoadBalancer()
+				->getMaintenanceConnectionRef( DB_PRIMARY );
 		$property_table_name = $dbw->tableName( PropertyTypeDbInfo::tableName( $this->propertyType() ) );
 		$revision_table_name = $dbw->tableName( 'revision' );
 		$page_props_table_name = $dbw->tableName( 'page_props' );
@@ -277,7 +282,9 @@ public function getAllValues(): PossibleFilterValues {
 	}
 
 	private function getTimePeriod() {
-		$dbw = wfGetDB( DB_PRIMARY );
+		$dbw = MediaWikiServices::getInstance()
+				->getDBLoadBalancer()
+				->getMaintenanceConnectionRef( DB_PRIMARY );
 		$property_value = $this->escapedProperty();
 		$date_field = PropertyTypeDbInfo::dateField( $this->propertyType() );
 		$datesTable = $dbw->tableName( PropertyTypeDbInfo::tableName( $this->propertyType() ) );

includes/PageSchemas.php

@@ -3,6 +3,7 @@
 namespace SD;
 
 use Html;
+use MediaWiki\MediaWikiServices;
 
 /**
  * Static functions for Semantic Drilldown, for use by the Page Schemas
@@ -105,7 +106,10 @@ public static function getFieldEditingHTML( $psField ) {
 		$html_text .= wfMessage( 'sd_createfilter_usepropertyvalues' )->text() . "\n";
 		$html_text .= Html::input( 'sd_values_source_num', 'category', 'radio', $fromCategoryAttrs ) . "\n";
 		$html_text .= "\t" . wfMessage( 'sd_createfilter_usecategoryvalues' )->text() . "\n";
-		$categories = ( new DbService( null, wfGetDB( DB_REPLICA ) ) )->getTopLevelCategories();
+		$dbr = MediaWikiServices::getInstance()
+			->getDBLoadBalancer()
+			->getMaintenanceConnectionRef( DB_REPLICA );
+		$categories = ( new DbService( null, $dbr ) )->getTopLevelCategories();
 		$categoriesHTML = "";
 		foreach ( $categories as $category ) {
 			$categoryOptionAttrs = [];

includes/Sql/SqlProvider.php

@@ -2,6 +2,7 @@
 
 namespace SD\Sql;
 
+use MediaWiki\MediaWikiServices;
 use SD\AppliedFilter;
 use SD\Utils;
 
@@ -47,7 +48,9 @@ public static function getSQLFromClauseForField( $new_filter ) {
 	 * @return string
 	 */
 	public static function getSQLFromClauseForCategory( $subcategory, $child_subcategories ) {
-		$dbr = wfGetDB( DB_REPLICA );
+		$dbr = MediaWikiServices::getInstance()
+			->getDBLoadBalancer()
+			->getMaintenanceConnectionRef( DB_REPLICA );
 		$smwIDs = $dbr->tableName( Utils::getIDsTableName() );
 		$smwCategoryInstances = $dbr->tableName( Utils::getCategoryInstancesTableName() );
 		$ns_cat = NS_CATEGORY;
@@ -78,7 +81,9 @@ public static function getSQLFromClauseForCategory( $subcategory, $child_subcate
 	 * @return string
 	 */
 	public static function getSQLFromClause( string $category, string $subcategory, array $subcategories, array $applied_filters ) {
-		$dbr = wfGetDB( DB_REPLICA );
+		$dbr = MediaWikiServices::getInstance()
+			->getDBLoadBalancer()
+			->getMaintenanceConnectionRef( DB_REPLICA );
 		$smwIDs = $dbr->tableName( Utils::getIDsTableName() );
 		$smwCategoryInstances = $dbr->tableName( Utils::getCategoryInstancesTableName() );
 		$cat_ns = NS_CATEGORY;

psalm.xml

@@ -27,7 +27,6 @@
       <UndefinedFunction>
         <errorLevel type="suppress">
           <referencedFunction name="wfMessage" />
-          <referencedFunction name="wfGetDB" />
         </errorLevel>
       </UndefinedFunction>
     </issueHandlers>