Error message about "𝘪𝘯𝘤𝘰𝘳𝘳𝘦𝘤𝘵 𝘴𝘰𝘶𝘳𝘤𝘦" when downloaded from CurseForge

[NatoBoram]

Information

Minecraft version: 1.18.2
Modloader: Fabric
Fabric loader version: 0.13.3-1.18.2
Environment: Singleplayer

Mod name: Collective
Mod version: collective-fabric-1.18.x-4.13.jar

Mod name: Easy Elytra Takeoff
Mod version: easyelytratakeoff-fabric_1.18.x-2.2

Description

When downloading the mods from https://www.curseforge.com/minecraft/mc-mods/collective-fabric and https://www.curseforge.com/minecraft/mc-mods/easy-elytra-takeoff-fabric, it displays an error message about not being downloaded from the "correct" "source".

Crash report

[ricksouth]

Could you show me a screenshot of the /mods folder, with the jar file names?

[NatoBoram]

Heh, I figured out what happened.

Basically, you hard-coded $pwd/mods in getModDirectory and you hard-coded the mod's name in jarname. You then use both of them to trip checkIfAllJarsExist.

Of course it's not gonna work.

[ricksouth]

It's a fragile system for sure, but an attempt to stop the hundreds of reposting sites. Thanks for the screenshot and I'll try to make it work for these cases!

For now you can either remove the check in the collective config, or keep it like this because the message won't show up again. Thanks for giving them a try, and downloading from CurseForge of course :)

[ricksouth]

Where did you change the mod directory folder? Or is this built in functionality?

[NatoBoram]

It's built-in with Fabric, but fairly hard to access. It's for modded client developers, so they can create separate Minecraft installation folders for every Minecraft version automatically.

• Add --fabric.addMods / -Dfabric.addMods for adding extra path separator separated mods, list file if prefixed with @ FabricMC/fabric-loader#470 (comment)

Not a fan of this since the disadvantages of creating one installation per version outweighs having versionned, but at least there's a command-line argument to do what I want.

[ricksouth]

Thanks! I'll take a look at adding the functionality.

[ricksouth]

Could you update Collective to version 4.19 I just uploaded, delete the ./data/collective folder in your minecraft root folder and see if the message still shows up? It'd be much appreciated! It should not show up.

https://www.curseforge.com/minecraft/mc-mods/collective-fabric/files

[NatoBoram]

I noticed that your mod is the only one writing in ./data out of my 26 mods. Can you use ./config instead for this one? There's many mods writing in many places, and data makes it seem like it's something important related to Minecraft itself.

Also your config file uses JSONC but has the .json extension; it would be appropriate to rename it .jsonc to avoid confusion. JSON editors are not able to handle JSONC, so that distinction is important for users.

I just tested it and the message doesn't appear. Thanks!

[Swoofterkitty]

I just encountered this after updating to collective version 7.36, downloaded thru the curseforge launcher

[ricksouth]

I just encountered this after updating to collective version 7.36, downloaded thru the curseforge launcher

Did you rename any of the mod files? Can you post a screenshot from your mods folder?

[Swoofterkitty]

Yeah I can, sorry for the delay
I did not rename any mods, all downloaded straight from curseforge.

Here is the modpack exported

Fuckshit TIME.zip

[ricksouth]

That's strange. Could you open a new issue for this? I'll try to take a look as soon as possible.