Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.apply_func() fails silently if args and kwargs are not specified correctly #34

Open
KMarkert opened this issue Jan 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@KMarkert
Copy link
Collaborator

See #33. When using .apply_func() and the kwargs passed to the function are not correct then the method returns None. This causes issues for downstream processing when the assigned variable is expected to be something different.

The optimal result will be if the args and kwargs passed the the function are not correct then the method will provide an error. This will require some checking for the arguments when creating the partial function at https://github.com/Servir-Mekong/hydra-floods/blob/master/hydrafloods/datasets.py#L235. In fact, looks like the args are not even passed so that needs to be fixed...

@KMarkert KMarkert added the bug Something isn't working label Jan 14, 2022
@KMarkert KMarkert self-assigned this Jan 14, 2022
@KMarkert KMarkert changed the title .appy_func() fails silently if args and kwargs are not specified correctly .apply_func() fails silently if args and kwargs are not specified correctly Jan 25, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment to keep open or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 25, 2022
@KMarkert KMarkert removed the Stale label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant