Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaults for Gong Fu style #19

Open
Elinvention opened this issue Feb 4, 2023 · 6 comments
Open

Add defaults for Gong Fu style #19

Elinvention opened this issue Feb 4, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Elinvention
Copy link

I think the app is suggesting the wrong concentration value for every tea. For example green tea should be 5g / 100ml, instead the app says 0.5g / 100ml, which is just too few tea leaves.
Thanks for this very useful app.

@Sesu8642
Copy link
Owner

Sesu8642 commented Feb 4, 2023

Thanks for your feedback!
The default data is based on the tea brewing guide my Mei Leaf. As you can see, the amount for green tea is actually 0.5g for western style brewing. For Gong Fu style brewing, the amount is quite a bit higher and brewing times differ as well.
The best way to brew your tea of course depends on the specific tea as well as your personal preference. You can always adjust the default settings or create a new tea entry.
Maybe the real problem here is that I only include defaults for western style brewing. But I also don't want to overwhelm new users even more. Not sure how to solve this...

@Sesu8642 Sesu8642 added the enhancement New feature or request label Feb 4, 2023
@victornoel
Copy link

Hi :) I was coming for the same issue!

What about including both gongfucha and Western defaults and maybe an option to hide some of the options so that users can choose what they want to see when they open the app?

@Elinvention
Copy link
Author

I'm so used to Gong Fu style that I totally missed the western style option 😄

I will just update the values with the information from that guide, thanks.

Just to add something more to @victornoel answer, to improve the UX even more, you could add an initial presentation and configuration wizard that asks the user to choose the style that they prefer.

@victornoel
Copy link

Good idea yep :)

In any case this is not blocking at all, I will also add those data in the app manually and anyway, I expect to very quickly adapt them to my particular case.

Great app!

@Sesu8642
Copy link
Owner

Sesu8642 commented Feb 7, 2023

I like your ideas. The only issue I see is that the default teas would need to be marked as such internally.

For older installations, I cannot reliably determine which ones were the defaults. This makes a migration tricky. I guess for app upgrades, I could treat all saved teas as "manually added" and disable both types of defaults.

Another potential problem is that the defaults can be edited completely. Someone could take the default entry for green teas and change it to contain the information about some random specific tea they have. If they then disable the default entries, their specific tea will be hidden as well - possibly unexpected.
Of course, I could disable editing of the defaults. But then you can no longer adjust them to your preference.
A potential solution could be to have the option to easily "clone" a tea or use it as a template, which I intend to implement anyway. This however comes with the disadvantage of still having the original template in the collection along with the adjusted one. This in turn could be solved by having the ability to hide individual default teas.

Any thoughts on this?

@Sesu8642 Sesu8642 changed the title Tea leaves concentrations are wrong by 10 fold decrease Add defaults for Gong Fu style Feb 7, 2023
@victornoel
Copy link

Hey @Sesu8642, sorry for the late answer :)

Maybe an idea would be to separate the list of default entries from the list of entries used by the user.

On upgrade, you could notify them the first time: "Hey, there are new default teas available that you may want to include in your everyday tea list, click here to see them. You can always find them later in the settings".
On first installation, you could present this something similar to the user: "hey, here are the default teas available, select the teas that you want in your everyday tea list. You will always be able to find them later in the settings".

Then you show a list (accessible via the notification or via the settings) where the user can select which entries they want to add to their everyday list.

And we can forget about that idea of disabling entries that I proposed or the idea of editing defaults: the defaults are not editable but they are templates that can be added (copied!) to the user's tea list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants