Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one <form> element instead of many in profile-component.html #39

Closed
nok-ko opened this issue May 13, 2022 · 1 comment
Closed

Use one <form> element instead of many in profile-component.html #39

nok-ko opened this issue May 13, 2022 · 1 comment

Comments

@nok-ko
Copy link
Collaborator

nok-ko commented May 13, 2022

Why do you have multiple <form> elements in this HTML file? Why not just use one <form> with many <input>s inside it?

Also, I think these inputs should have <label> elements.

From MDN:

Associating a <label> with an <input> element offers some major advantages:

  • The label text is not only visually associated with its corresponding text input; it is programmatically associated with it too. This means that, for example, a screen reader will read out the label when the user is focused on the form input, making it easier for an assistive technology user to understand what data should be entered.
  • When a user clicks or touches/taps a label, the browser passes the focus to its associated input (the resulting event is also raised for the input). That increased hit area for focusing the input provides an advantage to anyone trying to activate it – including those using a touch-screen device.

Originally posted by @nok-ko in #26 (comment)

@speakingoftime
Copy link
Collaborator

done! #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants