Skip to content

[BUG] on advancement done seems to trigger a lot more times than its supposed to #929

@Willio2000

Description

@Willio2000

What happened?

this is code that outputs "yup" when on advancement done is triggered:

on player advancement done:
	broadcast "yup"

this image is what happens if i get an iron ingot with that script enabled:
Image

the yup broadcast triggers 5 times before i get the advancement text and 22 times after it

Steps to reproduce

  1. copy the code that outputs "yup" when on advancement done is triggered from above
  2. paste it into a script
  3. run the server and get an advancement, some advancements make it only trigger once, like getting a crafting table, and some make it trigger multiple times, like getting iron

Expected behavior

it should only trigger once, before the advancement text is sent so it is cancelable

SkBee Version

3.17.0

Server Version

Paper 1.21.11

SkBee Info

[15:39:15 INFO]: - Plugin is not up to date!
[15:39:15 INFO]: - - Current version: v3.17.0
[15:39:15 INFO]: - - Available update: v3.17.1
[15:39:15 INFO]: - - Download at: https://modrinth.com/plugin/skbee/version/3.17.1
[15:39:15 INFO]: --- [Server Info] ---
[15:39:15 INFO]: Server Version: Paper 1.21.11-117-79c77f5 (MC: 1.21.11)
[15:39:15 INFO]: Skript Version: 2.14.1 (skriptlang-github)
[15:39:15 INFO]: Skript Addons:
[15:39:15 INFO]: SkBee Version: 3.17.0
[15:39:15 INFO]: SkBee Website: https://github.com/ShaneBeee/SkBee

Additional Information

skript 2.14.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs triageThis bug report/suggestion needs the team to look over

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions