remove js optional chaining expressions

Author: netkardam

eslint.config.mjs

@@ -32,7 +32,7 @@ export default defineConfig([
                 Cypress: true
             },
 
-            ecmaVersion: 2022,
+            ecmaVersion: 2018,
             sourceType: 'module'
         },
 

reporter/allure-cypress/AllureReporter.js

@@ -82,8 +82,8 @@ module.exports = class AllureReporter {
     get testNameForAttachment() {
         const cyTest = cy.state().test;
         return (
-            cyTest?.title ||
-            this.currentTest?.info.name ||
+            (cyTest && cyTest.title) ||
+            (this.currentTest && this.currentTest.info.name) ||
             this.previousTestName
         );
     }
@@ -244,15 +244,19 @@ module.exports = class AllureReporter {
         this.currentTest.info.stage = Stage.RUNNING;
         this.addPackageLabel();
 
-        if (config?.clearFilesForPreviousAttempt() && test._currentRetry > 0) {
+        if (
+            config &&
+            config.clearFilesForPreviousAttempt() &&
+            test._currentRetry > 0
+        ) {
             logger.allure(`clearing screenshots from previous retries`);
             // remove screenshots from previous attempt
             this.files = this.files.filter(
                 (file) => file.testName !== test.title
             );
         }
 
-        if (config?.addAnalyticLabels()) {
+        if (config && config.addAnalyticLabels()) {
             logger.allure(`adding analytic labels`);
             this.currentTest.addLabel(LabelName.FRAMEWORK, 'Cypress');
             const language = languageLabel(test);
@@ -387,9 +391,12 @@ module.exports = class AllureReporter {
     }
 
     finishRemainingSteps(status = Status.PASSED) {
-        const alreadyHasFailedStep = this.currentTest?.info?.steps.some(
-            (step) => step.status === Status.FAILED
-        );
+        const alreadyHasFailedStep =
+            this.currentTest &&
+            this.currentTest.info &&
+            this.currentTest.info.steps.some(
+                (step) => step.status === Status.FAILED
+            );
 
         this.steps.forEach((step) => {
             step.info.stage = Stage.FINISHED;
@@ -474,7 +481,7 @@ module.exports = class AllureReporter {
 
         // in case hook is a step we should complete it
         if (this.originalNameOf(hook).includes('each')) {
-            this.currentHook?.endStep();
+            this.currentHook && this.currentHook.endStep();
         }
         !isAllureReport && !failed && (this.currentHook = null);
         this.finishRemainingSteps(currentHookInfo.status);
@@ -527,7 +534,8 @@ module.exports = class AllureReporter {
         }
         // update test, which may had a pending event previously
         if (
-            test?.state &&
+            test &&
+            test.state &&
             [Status.FAILED, Status.PASSED, Status.SKIPPED].includes(test.state)
         ) {
             this.updateTest(

reporter/index.js

@@ -75,12 +75,17 @@ const config = {
 };
 
 const invokeResultsWriter = (allure, isGlobal) => {
-    if (!config?.allureEnabled()) {
+    if (!config || !config.allureEnabled()) {
         return;
     }
     try {
         clearAllureHookStepsFromTests(
-            allure.reporter.runtime.config?.writer?.tests,
+            allure &&
+                allure.reporter &&
+                allure.reporter.runtime &&
+                allure.reporter.runtime.config &&
+                allure.reporter.runtime.config.writer &&
+                allure.reporter.runtime.config.writer.tests,
             config.logAllureHooksEnabled()
         );
         return cy
@@ -207,7 +212,10 @@ class CypressAllureReporter {
             if (log.state === 'failed') {
                 logger.cy('found failed log:added %O', log);
 
-                if (this.reporter.currentExecutable?.info) {
+                if (
+                    this.reporter.currentExecutable &&
+                    this.reporter.currentExecutable.info
+                ) {
                     this.reporter.currentExecutable.info.status = 'failed';
                 }
             }
@@ -233,7 +241,7 @@ class CypressAllureReporter {
             logger.cy(`found gherkin step, creating allure entity`);
             const step = this.reporter.cy.startStep(command, {
                 ...log,
-                displayName: log?.displayName || log.name,
+                displayName: (log && log.displayName) || log.name,
                 name: 'step'
             });
 
@@ -292,7 +300,9 @@ Cypress.Screenshot.defaults({
         logger.cy(`onAfterScreenshot: %O`, details);
         setTestIdToScreenshot(
             config.allureEnabled(),
-            Cypress.Allure?.reporter?.mochaIdToAllure,
+            Cypress.Allure &&
+                Cypress.Allure.reporter &&
+                Cypress.Allure.reporter.mochaIdToAllure,
             details
         );
         if (

reporter/patching.js

@@ -42,7 +42,7 @@ const reorderAllureHooksGeneric = (
 };
 
 const clearAllureHookSteps = (test, allureLogHooks = false) => {
-    if (!test?.steps?.length) {
+    if (!(test && test.steps && test.steps.length)) {
         return test;
     }
 
@@ -98,13 +98,13 @@ const isLastRootHook = () => {
     }
     const { hookName } = currentRunnable;
     let rootSuite = currentRunnable.parent;
-    while (rootSuite?.parent && !rootSuite.root) {
+    while (rootSuite && rootSuite.parent && !rootSuite.root) {
         rootSuite = rootSuite.parent;
     }
     if (!rootSuite) {
         return false;
     }
-    const hooks = rootSuite?.hooks || [];
+    const hooks = (rootSuite && rootSuite.hooks) || [];
     const lastHook = hooks.findLast((h) => h.hookName === hookName);
 
     return lastHook && lastHook.hookId === currentRunnable.hookId;
@@ -114,7 +114,7 @@ const setTestIdToScreenshot = (allureEnabled, mochaIdToAllure, details) => {
     if (allureEnabled) {
         let currentTest = cy.state('test');
         if (details && currentTest && mochaIdToAllure) {
-            const testIds = mochaIdToAllure[currentTest?.id];
+            const testIds = mochaIdToAllure[currentTest && currentTest.id];
             if (testIds) {
                 details['testId'] = currentTest.id;
                 let testId = testIds.at(-1);

writer/attachments.js

@@ -22,7 +22,7 @@ const attachScreenshotsAndVideo = (allureMapping, results, config) => {
 
     const needVideo = results.tests.filter((test, index) => {
         let shouldAttachVideo = false;
-        test.testId = test?.testId || testIdIndex[index];
+        test.testId = (test && test.testId) || testIdIndex[index];
         const testIds = allureMapping[test.testId];
         if (!testIds) {
             return false;

writer/handleMultiDomain.js

@@ -75,7 +75,7 @@ const sanitizeSuites = (folder, files = [], isGlobal = false) => {
                 continue;
             }
 
-            if (child?.steps?.length) {
+            if (child && child.steps && child.steps.length) {
                 logger.writer('child %s %s has steps', child.uuid, child.name);
                 continue;
             }
@@ -84,7 +84,8 @@ const sanitizeSuites = (folder, files = [], isGlobal = false) => {
                 (file) =>
                     file.historyId === child.historyId &&
                     file.uuid !== child.uuid &&
-                    file?.steps?.length
+                    file.steps &&
+                    file.steps.length
             );
 
             duplicates.sort((a, b) => a.start - b.start);