Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The HardCodedString linter is not documented #254

Closed
danielittlewood0 opened this issue May 20, 2022 · 2 comments · Fixed by #278
Closed

The HardCodedString linter is not documented #254

danielittlewood0 opened this issue May 20, 2022 · 2 comments · Fixed by #278
Labels
documentation

Comments

@danielittlewood0
Copy link

Steps to reproduce

  • Manually enable all linters mentioned in the documentation.
  • Fix all errors.
  • Run erb-lint --lint-all --enable-all-linters.
  • Expect: No errors reported.
  • Actual: Several "String not translated" errors.

I looked into it and this is related to the HardCodedString linter. If I enable that linter manually, then the problem goes away. I couldn't find any other examples of existing linters that were unmentioned.
@francisfuzz francisfuzz mentioned this issue Oct 12, 2022
Merged
@francisfuzz
Copy link
Contributor

I recently ran into this today! Thanks for opening an issue - I cut #278 as an attempt to resolve this.

@samrjenkins
Copy link

I just ran into this issue. Would be awesome to get this resolved. Had me confused for a few minutes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(README.md): include HardCodedString linter francisfuzz/erb-lint
4 participants
@rafaelfranca @francisfuzz @danielittlewood0 @samrjenkins