Switch from deprecated Cop.all API to Rubocop v1 Registry.all #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
vokshirg
approved these changes
Jul 18, 2024
|
the warnings with latest Rubocop are annoying, would be great to have this released, let me know if I can help in any way. |
| @@ -28,7 +28,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency("better_html", ">= 2.0.1") | |||
| s.add_dependency("parser", ">= 2.7.1.4") | |||
| s.add_dependency("rainbow") | |||
| s.add_dependency("rubocop") | |||
| s.add_dependency("rubocop", ">= 1") | |||
There was a problem hiding this comment.
If this changes, Gemfile.lock should change with it.
There was a problem hiding this comment.
Just pushed a new commit with that change.
etiennebarrie
added a commit
that referenced
this pull request
Jul 30, 2024
|
You didn't allow maintainers to edit the pull request so I pushed the changes on main in 0d39442 directly. Thanks! |
|
When will this be released to rubygems? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API change is noted in the V1 upgrade notes here, so there's also a
>= 1requirement on therubocopgem: https://docs.rubocop.org/rubocop/v1_upgrade_notes.htmlWithout this,
erb-lintwinds up emitting a ton of deprecation warnings when used withrubocop>= 1.65.0, which introduces warning messages for deprecated APIs: rubocop/rubocop#13032