New contribution proposal: Icons for media editing #11792
Closed
dGoligorsky
started this conversation in
Contribution proposals
Replies: 1 comment
-
Got the Figma branch in the UI Kit approved and will go forward with making a PR. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
TL;DR
There's a few icons in use for Magic Media Generation that aren't in Polaris. That's the feature where product images can have the background removed and replaced with a solid color or a generated background image.
Figma for the unflattened icons
Champion
David Goligorsky
Stakeholders
Arda Karaçizmeli (Magic Media web, he is aware), Joe Thomas (icon lord)
Estimated timeline
I'll flatten and optimize the svgs and do a PR once we're happy w design.
What problem are you solving?
Just an icon contribution so we're using the desktop/mobile Polaris icons.
How does your solution improve Polaris?
There's some non-componentized svg icons floating around, they should be Polaris icons.
Have you tested and verified your solution?
Nope
What is the scope of work?
Will do updates in Figma UI Kit and PR for the icon svg and yml
What is the impact on existing implementations, and do you have a plan to address it?
I'll get mobile and web to flip from hardcoded svgs to using the components.
Are there any known blockers or risks?
Nope
Beta Was this translation helpful? Give feedback.
All reactions