Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build filename code added temporarily for backwards compat #11348

Closed
jesstelford opened this issue Dec 14, 2023 · 3 comments
Closed

Cleanup build filename code added temporarily for backwards compat #11348

jesstelford opened this issue Dec 14, 2023 · 3 comments
Labels
no-issue-activity v14.0.0 Tracking the work for @shopify/polaris v14.0.0 release

Comments

@jesstelford
Copy link
Contributor

Originally posted by @sam-b-rose in #11340 (review):

Do we need to support backwards compatibility with the filename? I would think that is something consumers shouldn't rely on being static.

It is certainly reasonable to support this backwards compatibility, but it does add extra overhead and clutter to out build process. We could remove this in the next major, though just wanted to examine if it is really something we'd consider a breaking change.

@jesstelford jesstelford added the v13.0.0 Tracking all work for @shopify/polaris-react v13.0.0 label Dec 14, 2023
@BPScott
Copy link
Member

BPScott commented Dec 15, 2023

With the Vite in admin stuff, I'm reasonably sure it no longer bothers to look for esnext code in packages (@vsumner can confirm if that's the case now and/or if it is slated to return)

If that's never coming back then perhaps there's a world where polaris stops bothering to create the esnext bundle entirely?

@jesstelford
Copy link
Contributor Author

Love it!

@jesstelford jesstelford added v14.0.0 Tracking the work for @shopify/polaris v14.0.0 release and removed v13.0.0 Tracking all work for @shopify/polaris-react v13.0.0 labels Mar 15, 2024
Copy link
Contributor

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity v14.0.0 Tracking the work for @shopify/polaris v14.0.0 release
Projects
None yet
Development

No branches or pull requests

2 participants